Skip to content

Conversation

ajinkya-k
Copy link
Contributor

  • Fixed some typos in the documentation, like repeated words and missing closing parentheses.
  • Put package names inside backquotes in multiple places

Did behavior change? Did you add need features? No

Copy link

codecov bot commented Mar 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.33%. Comparing base (19c37bb) to head (c54fcd2).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #812   +/-   ##
=======================================
  Coverage   97.33%   97.33%           
=======================================
  Files          36       36           
  Lines        3495     3495           
=======================================
  Hits         3402     3402           
  Misses         93       93           
Flag Coverage Δ
current 96.99% <ø> (ø)
minimum 97.33% <ø> (ø)
nightly 96.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ajinkya-k
Copy link
Contributor Author

@palday does the CI workflow for documentation deployment automatically install latest versions for the dependencies? DocumenterVitepress must be at the latest version I think for the contents block to work well

@palday
Copy link
Member

palday commented Mar 26, 2025

@palday does the CI workflow for documentation deployment automatically install latest versions for the dependencies? DocumenterVitepress must be at the latest version I think for the contents block to work well

The CI workflow will update the packages to the latest compatible versions as limited by the docs/Project.toml.

One thing I'm still looking at is how to integrate the deploy step from VitePress -- it's decidedly more complicated than the base Documenter.jl implementation, at least from my perspective.

@ajinkya-k
Copy link
Contributor Author

I agree. I can experiment with CI on my fork as a test. Can you help me with how to trigger a deployment ?

@ajinkya-k
Copy link
Contributor Author

Oh btw this PR has nothing to do with Vitepress

@ajinkya-k
Copy link
Contributor Author

@palday this PR is just small fixes to formatting. Do you think this is good to merge?

Copy link
Collaborator

@dmbates dmbates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for checking all these files.

@dmbates dmbates merged commit 1be8517 into JuliaStats:main Mar 30, 2025
11 checks passed
@ajinkya-k ajinkya-k deleted the ahk/docfix branch March 30, 2025 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants