Skip to content

added StatsAPI.mss(m::LinearMixedModel) #816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

added StatsAPI.mss(m::LinearMixedModel) #816

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
43bab38
added StatsAPI.mss(m::LinearMixedModel)
ajinkya-k Mar 22, 2025
b15ba2e
fixed MSS formula for linear mixed effects models
ajinkya-k Mar 30, 2025
2e3bb5c
clean up mss definition a little
palday Mar 31, 2025
eb75ca9
tweak tolerance
palday Mar 31, 2025
c7c365f
tweaked error message for MSS
ajinkya-k Mar 31, 2025
9a0a329
Merge branch 'main' into ahk/statsapi
ajinkya-k Mar 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/linearmixedmodel.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1212,6 +1212,8 @@
return stderror!(similar(pivot(m), T), m)
end

StatsAPI.mss(m::LinearMixedModel) = sum(abs2.(mean(m.y) .- fitted(m)))

Check warning on line 1215 in src/linearmixedmodel.jl

View check run for this annotation

Codecov / codecov/patch

src/linearmixedmodel.jl#L1215 

Added line #L1215 was not covered by tests

"""
updateA!(m::LinearMixedModel)

Expand Down
2 changes: 2 additions & 0 deletions test/fit.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ using Test
@test deviance(m1) ≈ deviance(m2)
@test isa(lmm(@formula(yield ~ 1 + (1|batch)), MixedModels.dataset(:dyestuff); progress=false, REML = true), LinearMixedModel)

@test_broken mss(m1) ≈ 30780.69

# example from https://github.com/JuliaStats/MixedModels.jl/issues/194
# copied from tetst/pls.jl
data = (
Expand Down
Loading