remove local definitions of fulldummy and nesting operator #855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are now implemented as part of RegressionFormulae.jl. At some point, we may need to provide more specialized methods for complex random effects structures (i.e. interaction with correlation suppression), but these can and should be implemented as methods of RegressionFormuale.jl's functions.
15 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #855 +/- ##
==========================================
+ Coverage 95.45% 95.51% +0.06%
==========================================
Files 38 38
Lines 3699 3683 -16
==========================================
- Hits 3531 3518 -13
+ Misses 168 165 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
palday
force-pushed
the
pa/regression-formulae
branch
from
8e6d75e to
c1e4b9d
Compare
dmbates
approved these changes
Aug 26, 2025
…egression-formulae
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #599
These are now implemented as part of RegressionFormulae.jl. At some point, we may need to provide more specialized methods for complex random effects structures (i.e. interaction with correlation suppression), but these can and should be implemented as methods of RegressionFormuale.jl's functions.
I also added some docs on the formula language, which will help avoid some of the confusion in e.g. #831.