Skip to content

Conversation

palday
Copy link
Member

@palday palday commented Aug 23, 2025

closes #817

  • add entry in NEWS.md

@palday palday changed the title all specifying type argument n GLMMi predict on original data allow specifying type argument in GLMM predict on original data Aug 23, 2025
@palday palday marked this pull request as ready for review August 23, 2025 19:50
@dmbates
Copy link
Collaborator

dmbates commented Aug 24, 2025

I guess I should have been more careful about the approval. I didn't notice the test failures. Let me know if you want me to take a look.

@codecov
Copy link

codecov bot commented Aug 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.54%. Comparing base (6408a34) to head (be52f8b).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #856   +/-   ##
=======================================
  Coverage   95.54%   95.54%           
=======================================
  Files          38       38           
  Lines        3700     3703    +3     
=======================================
+ Hits         3535     3538    +3     
  Misses        165      165           
Flag Coverage Δ
current 95.21% <100.00%> (+<0.01%) ⬆️
minimum 95.54% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@palday palday merged commit 7b17e0e into main Aug 25, 2025
11 of 12 checks passed
@palday palday deleted the pa/predict-glmm branch August 25, 2025 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Should there be a method for predict(m::GenearlizedLinearMixedModel; type = ...)

2 participants