Skip to content

Conversation

palday
Copy link
Member

@palday palday commented Aug 25, 2025

closes #818. closes #633

This has been needlessly confusing for a lot of people, I think, so now the only difference is in the display methods.

  • add entry in NEWS.md
  • after opening this PR, add a reference and run docs/NEWS-update.jl to update the cross-references.

@palday palday changed the base branch from pa/deprecation-removal-5.0 to main August 25, 2025 14:43
@palday palday changed the title rework likelihoodratio test to be just a pretty-printing wrapper arounnd lrtest rework likelihoodratio test to be just a pretty-printing wrapper around lrtest Aug 25, 2025
Copy link

codecov bot commented Aug 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.45%. Comparing base (6841af6) to head (54b2546).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #858      +/-   ##
==========================================
+ Coverage   95.41%   95.45%   +0.04%     
==========================================
  Files          38       38              
  Lines        3710     3699      -11     
==========================================
- Hits         3540     3531       -9     
+ Misses        170      168       -2     
Flag Coverage Δ
current 95.15% <98.57%> (+0.06%) ⬆️
minimum 95.45% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@palday palday marked this pull request as ready for review August 25, 2025 20:09
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
palday and others added 3 commits August 25, 2025 23:51
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@palday palday merged commit b61a60a into main Aug 26, 2025
11 of 12 checks passed
@palday palday deleted the pa/lrt branch August 26, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

export likelihoodratiotest using an alias for non-nested tests Always use -2 loglikelihood instead of deviance for LRT computations
2 participants