-
Notifications
You must be signed in to change notification settings - Fork 49
fix display and confint of bootstrap for models without dispersion parameter #861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #861 +/- ##
=======================================
Coverage 95.45% 95.46%
=======================================
Files 38 38
Lines 3676 3681 +5
=======================================
+ Hits 3509 3514 +5
Misses 167 167
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine to me but I would appreciate if @ararslan also had a look.
@ararslan I need this for demo'ig something today, but posthoc review is appreciated! |
par = filter(collect(propertynames(tbl))) do k | ||
k = string(k) | ||
# σ is missing in models without a dispersion parameter | ||
if k == "σ" && Missing <: eltype(tbl.σ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be safer, albeit slower, to check any(ismissing, tbl.σ)
in case inference decides that the element type of tbl.σ
is Any
. You could do something like
Tσ = eltype(tbl.σ)
if k == "σ" && ((Tσ !== Any && Missing <: Tσ) || (Tσ === Any && any(ismissing, tbl.σ)))
return false
end
closes #859
docs/NEWS-update.jl
to update the cross-references.