Skip to content

Conversation

palday
Copy link
Member

@palday palday commented Aug 28, 2025

closes #859

  • add entry in NEWS.md
  • after opening this PR, add a reference and run docs/NEWS-update.jl to update the cross-references.
  • I've bumped the version appropriately

@palday palday requested a review from dmbates August 28, 2025 10:52
@palday palday marked this pull request as ready for review August 28, 2025 10:52
Copy link

codecov bot commented Aug 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.46%. Comparing base (50f0ac9) to head (9744074).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #861   +/-   ##
=======================================
  Coverage   95.45%   95.46%           
=======================================
  Files          38       38           
  Lines        3676     3681    +5     
=======================================
+ Hits         3509     3514    +5     
  Misses        167      167           
Flag Coverage Δ
current 95.16% <100.00%> (+<0.01%) ⬆️
minimum 95.46% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@palday palday requested a review from ararslan August 28, 2025 19:42
Copy link
Collaborator

@dmbates dmbates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me but I would appreciate if @ararslan also had a look.

@palday
Copy link
Member Author

palday commented Aug 29, 2025

@ararslan I need this for demo'ig something today, but posthoc review is appreciated!

@palday palday merged commit ec7b986 into main Aug 29, 2025
11 of 12 checks passed
@palday palday deleted the pa/glmmboot branch August 29, 2025 06:55
palday added a commit that referenced this pull request Aug 29, 2025
…rameter (#861)

* fix display and confint of bootstrap for models without dispersion parameter

* NEWS

* patch not minor

(cherry picked from commit ec7b986)
par = filter(collect(propertynames(tbl))) do k
k = string(k)
# σ is missing in models without a dispersion parameter
if k == "σ" && Missing <: eltype(tbl.σ)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be safer, albeit slower, to check any(ismissing, tbl.σ) in case inference decides that the element type of tbl.σ is Any. You could do something like

= eltype(tbl.σ)
if k == "σ" && ((Tσ !== Any && Missing <: Tσ) || (Tσ === Any && any(ismissing, tbl.σ)))
    return false
end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

default bootstrap table shows NaNs for sigmas in models without a dispersion parameter
3 participants