Skip to content

display fix for unlikely but possible type inference failure in bootstrap table #865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 10, 2025
Merged

display fix for unlikely but possible type inference failure in bootstrap table #865

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0dc81c5
display fix for unlikely but possible type inference failure in boots…
palday Sep 4, 2025
2b03e36
format
palday Sep 4, 2025
608c06c
Update src/bootstrap.jl
palday Sep 6, 2025
5b02e5b
Update src/bootstrap.jl
palday Sep 9, 2025
c13a7ca
Merge branch 'main' of github.com:JuliaStats/MixedModels.jl into pa/m…
palday Sep 9, 2025
e61011e
Update src/bootstrap.jl
palday Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
MixedModels v5.0.3 Release Notes
==============================
- Small update in some code related to displaying dispersion parameters in cases where inference has failed. [#865]

MixedModels v5.0.2 Release Notes
==============================
- The default display and `confint` methods for bootstrap results from models without dispersion parameters has been fixed. [#861]
Expand Down Expand Up @@ -695,3 +699,4 @@ Package dependencies
[#858]: https://github.com/JuliaStats/MixedModels.jl/issues/858
[#860]: https://github.com/JuliaStats/MixedModels.jl/issues/860
[#861]: https://github.com/JuliaStats/MixedModels.jl/issues/861
[#865]: https://github.com/JuliaStats/MixedModels.jl/issues/865
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "MixedModels"
uuid = "ff71e718-51f3-5ec2-a782-8ffcbfa3c316"
author = ["Phillip Alday <me@phillipalday.com>", "Douglas Bates <dmbates@gmail.com>"]
version = "5.0.2"
version = "5.0.3"

[deps]
Arrow = "69666777-d1a9-59fb-9406-91d4454c9d45"
Expand Down
5 changes: 4 additions & 1 deletion src/bootstrap.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,7 +359,10 @@ function StatsBase.confint(
par = filter(collect(propertynames(tbl))) do k
k = string(k)
# σ is missing in models without a dispersion parameter
if k == "σ" && Missing <: eltype(tbl.σ)
Tσ = eltype(tbl.σ)
# see https://github.com/JuliaStats/MixedModels.jl/pull/861#discussion_r2323094090
# for more info on why this logic is so convulated
if k == "σ" && ((Tσ === Any && any(ismissing, tbl.σ)) || Missing <: Tσ)
return false
end
return !startswith(k, 'θ') && k != "obj"
Expand Down
Loading