make nesting checks more robust and more informative #867
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #867 +/- ##
==========================================
+ Coverage 95.60% 95.61% +0.01%
==========================================
Files 38 38
Lines 3683 3694 +11
==========================================
+ Hits 3521 3532 +11
Misses 162 162
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| @error "Inner models have grouping variables not present in outer models." | ||
| return false | ||
| end | ||
| # check that every intercept/slope for a grouping var occurs in the |
There was a problem hiding this comment.
Is the reason for switching to setdiff just for clarity?
Also, both here and above there is a call to @error followed by return false. My guess is that the return false will never be called as @error does not return. I have no objections to this formulation but I am wondering if it is redundant.
There was a problem hiding this comment.
Yes, the change to setdiff is just for clarity.
@error just shows a log message. I think you're thinking of error which throws.
2 participants
docs/NEWS-update.jlto update the cross-references.