-
Notifications
You must be signed in to change notification settings - Fork 195
Make pairwise
multi-threaded and make corkendall
and corspearman
wrap pairwise
.
#923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
PGS62
wants to merge
24
commits into
JuliaStats:master
Choose a base branch
from
PGS62:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
c85116a
Rewrite pairwise, corkendall and corspearman
PGS62 8ced336
Delete rankcorrspeedtest.jl
PGS62 6a8fecd
Partial solution to test failures on Julia 1.0.5
PGS62 eff32e4
Reverted to using eachcol in the hope that support for Julia 1.0.5 wi…
PGS62 1a4d064
Deleted commented out tests
PGS62 893d4b6
Delete settings.json
PGS62 e2c9ef5
Update pairwise.jl in response to some of devmotion's comments
PGS62 4c2e7a0
Was calling copytry! too soon. Fixed that.
PGS62 2119804
Update pairwise.jl
PGS62 5da5943
nested loops more friendly to Julia being column-major
PGS62 baf193b
flipped i and j loop variables. reshape -> similar
PGS62 a1d9ae9
Added iterators EqualSumSubsets and TwoStepRange
PGS62 951b391
Int64 -> Int to work on 32bit
PGS62 75d206a
Update tests
PGS62 56d27cc
Update tests
PGS62 682859a
Tests now pass on Julia 1.8.5
PGS62 9c039dd
Compatibility with Julia 1.6
PGS62 f53b7b5
Test against Julia 1.6, 1.7, 1.8 and 1.9 to find possible new minimum…
PGS62 88bf8f6
Test on Julia 1.1, 1.2, 1.3. 1.4 and 1.5
PGS62 ddb1b51
Demonstrate that 1.6 could be new minimum version
PGS62 f67e867
Corrected call to keyword argument
PGS62 246f32d
Improved test coverage (src/pairwise.jl#L84-L87)
PGS62 46d5655
Improved test coverage (StatsBase._cor)
PGS62 e1395b8
Trivial change to re-run tests
PGS62 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
{} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.