Skip to content

Require at least Julia 1.6.6, 1.7.3 #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 31, 2025

Conversation

mortenpi
Copy link
Collaborator

This is the first Julia version that can handle nested addenv calls on Windows (for #64).

X-ref: #64 (comment)

This is the first Julia version that can handle nested `addenv` calls on Windows (for JuliaVersionControl#64).
Copy link

codecov bot commented Jul 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.96%. Comparing base (1201aed) to head (240fb8a).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #67   +/-   ##
=======================================
  Coverage   96.96%   96.96%           
=======================================
  Files           1        1           
  Lines          33       33           
=======================================
  Hits           32       32           
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mortenpi
Copy link
Collaborator Author

Although 1.7.0 also has the bug, which is still allowed by this compat. But this will let the CI pass at least. 1.8.0 is fine.

Alternatively, we could just bump to 1.10.0, as that's the LTS. 1.6.6 is just the most conservative bound.

cc @giordano @DilumAluthge

@giordano
Copy link
Member

I'm fine with bumping to 1.10

@DilumAluthge
Copy link
Member

Is there any release of 1.7.x that fixes the bug?

If the answer is no, then let's just bump to 1.8 (assuming that 1.8.0 fixes the bug).

IMO no need to drop support for 1.8 and 1.9 if we aren't forced to.

@cgarling
Copy link
Contributor

cgarling commented Jul 25, 2025

I'm going to bump the Julia compat in #64 to 1.8 and see if the CI passes with the added git-lfs tests over there

Edit: All tests passed on Julia 1.8.0 (the Julia min tests)

@mortenpi
Copy link
Collaborator Author

Is there any release of 1.7.x that fixes the bug?

On that branch, it looks like it got fixed in 1.7.3.

@mortenpi
Copy link
Collaborator Author

mortenpi commented Jul 25, 2025

Not really important, but I wonder if it was an unintended side-effect of this PR: JuliaLang/julia#44212

@mortenpi
Copy link
Collaborator Author

mortenpi commented Jul 25, 2025

Trying out an overly complicated compat here. But I'm also quite content with just 1.8.0 minimum (so feel free to close this).

@DilumAluthge
Copy link
Member

I'm always a fan of keeping support for old Julia versions, so I like this.

@mortenpi mortenpi changed the title Require at least Julia 1.6.6 Require at least Julia 1.6.6, 1.7.3 Jul 26, 2025
@giordano giordano merged commit d03efd1 into JuliaVersionControl:master Jul 31, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants