-
Notifications
You must be signed in to change notification settings - Fork 10
Require at least Julia 1.6.6, 1.7.3 #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is the first Julia version that can handle nested `addenv` calls on Windows (for JuliaVersionControl#64).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #67 +/- ##
=======================================
Coverage 96.96% 96.96%
=======================================
Files 1 1
Lines 33 33
=======================================
Hits 32 32
Misses 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Although 1.7.0 also has the bug, which is still allowed by this compat. But this will let the CI pass at least. 1.8.0 is fine. Alternatively, we could just bump to 1.10.0, as that's the LTS. 1.6.6 is just the most conservative bound. |
I'm fine with bumping to 1.10 |
Is there any release of 1.7.x that fixes the bug? If the answer is no, then let's just bump to 1.8 (assuming that 1.8.0 fixes the bug). IMO no need to drop support for 1.8 and 1.9 if we aren't forced to. |
I'm going to bump the Julia compat in #64 to 1.8 and see if the CI passes with the added Edit: All tests passed on Julia 1.8.0 (the Julia min tests) |
On that branch, it looks like it got fixed in 1.7.3. |
Not really important, but I wonder if it was an unintended side-effect of this PR: JuliaLang/julia#44212 |
Trying out an overly complicated compat here. But I'm also quite content with just 1.8.0 minimum (so feel free to close this). |
I'm always a fan of keeping support for old Julia versions, so I like this. |
This is the first Julia version that can handle nested
addenv
calls on Windows (for #64).X-ref: #64 (comment)