build: add script to patch API URL for runtime #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The application currently loads the API URL by trying a PageConfig option and then falling back to a localhost hardcoded URL. This yarn script uses `jq` to inject the environment variable API_URL into the built app's config at `dist/jupyter-lite.json`. Additionally, a yarn script `build:all:prod` tacks this script on at the end so that you can run API_URL=... jlpm build:all:prod
|
@agriyakhetarpal what do you think of this as the way to solve #69? The deployment can just be modified to use an env var with the build script |
agriyakhetarpal
added
the
maintenance
There was a problem hiding this comment.
Hi @adamblake, this approach sounds good to me. Could you please also update the lite matrix of jobs in build.yml so that it calls build:all:prod for the production case? Thank you!
|
(Deleted the wrong branch, sorry – I was meaning to pull this locally) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The application currently loads the API URL by trying a PageConfig option and then falling back to a localhost hardcoded URL. This yarn script uses
jqto inject the environment variable API_URL into the built app's config atdist/jupyter-lite.json.Additionally, a yarn script
build:all:prodtacks this script on at the end so that you can runAPI_URL=... jlpm build:all:prod