Sharing service token refresh and persistence draft #197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agriyakhetarpal
commented
Aug 13, 2025
Comment on lines
+255
to
+271
| /** | ||
| * Perform a "log out"-like action by asking the server to clear the | ||
| * HttpOnly cookie, and then drop our in-memory token. | ||
| */ | ||
| async logout(): Promise<void> { | ||
| const endpoint = new URL('auth/logout', this.api_url); | ||
| try { | ||
| await fetch(endpoint, { | ||
| method: 'POST', | ||
| credentials: 'include', | ||
| headers: await this.makeHeaders() | ||
| }); | ||
| } finally { | ||
| this._token = undefined; | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
This requires an auth/logout API endpoint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
This PR is not yet complete, and needs changes on the sharing service as well.
We need to rely on the server to also set an
HttpOnlycookie for session persistence and lock down CSP and eliminate inline scripts, because XSS could steal the in-memory token.