Start CKHub sharing service as a part of the GHA integration tests #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agriyakhetarpal
commented
Jul 1, 2025
agriyakhetarpal
added
enhancement
agriyakhetarpal
removed
blocked
agriyakhetarpal
force-pushed
the
start-ckhub-api-gha
branch
from
cac420a to
54fbc2f
Compare
|
Okay, so the failing test says that it failed to share the notebook, but I'm not sure why that could be the case. This passes locally, both in headless and headed mode. 🤷🏻 The sharing service is set up correctly in CI as well. |
|
@adamblake, is it okay for us to switch to using the recently enabled https://dev.jupytereverywhere.org for our test suite? |
|
Yes please do, and I am going to wipe and replace staging with the new build process once I finish the CI/CD for dev. Reading through @agriyakhetarpal and @peytondmurray comments on that on Slack and starting implementation tomorrow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #52