Fix .Shallow() #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, the library would set ?shallow="true" (note the extra quotes), which would silently fail (because the .Iterator() method has no error return path). After this change, .Shallow() works and returns errors as expected.
When running the migrator on Gaurav's production data this timeout was hit often because he has ~40mb of data in firebase. Set the timeout to a minute to avoid that case.
Increase readWriteTimeout to 1 minute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, the library would set ?shallow="true" (note the extra quotes), which would silently fail because the .Iterator() method has no error return path.