Deprecate reusable workflows #67
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of this information should be reintroduced as example workflows
Contributor
|
What about just making a new workflow that incorporates the version in its name? I use these workflows in pretty much all my mods and removing them would be a huge pain. |
Member
Author
|
What do you mean “incorporates the version in its name” the workflows themselves can be pinned, but the actions within them always use @main |
Member
Author
|
|
drewcassidy
added a commit
that referenced
this pull request
Oct 29, 2025
From now on, release with `just release {{args}}` with the usual yaclog version args like `--patch` or `--minor`. It will automatically run `yaclog release` alongside updating all reusable workflows to have the correct tags. Pinning workflows to a branch (or leaving them unpinned) should be avoided from here on, only pin to tags.
The pin updating can be done on its own with `just pin-workflows {{ref}}`
Makes #67 unnecessary
commit 82828e9
Author: Andrew Cassidy <drewcassidy@me.com>
Date: Tue Oct 28 17:49:32 2025 -0700
Add note to the docs
commit f70929c
Author: Andrew Cassidy <drewcassidy@me.com>
Date: Tue Oct 28 17:41:19 2025 -0700
Only run checks for tag events
commit 108d8b8
Author: Andrew Cassidy <drewcassidy@me.com>
Date: Tue Oct 28 17:39:05 2025 -0700
Check for mismatches
this CI run should fail, I'll later restrict this check to only on tag pushes
commit bf2a436
Author: Andrew Cassidy <drewcassidy@me.com>
Date: Tue Oct 28 17:37:59 2025 -0700
Fix regex
commit adb4c77
Author: Andrew Cassidy <drewcassidy@me.com>
Date: Tue Oct 28 17:35:22 2025 -0700
Fix line endings
commit 0c99c7f
Author: Andrew Cassidy <drewcassidy@me.com>
Date: Tue Oct 28 17:21:15 2025 -0700
run yaclog via uv
this allows us to pin the version
commit 814ba63
Author: Andrew Cassidy <drewcassidy@me.com>
Date: Tue Oct 28 17:14:56 2025 -0700
Add tool to pin workflows while releasing a new version
drewcassidy
added a commit
that referenced
this pull request
Nov 7, 2025
From now on, release with `just release {{args}}` with the usual yaclog version args like `--patch` or `--minor`. It will automatically run `yaclog release` alongside updating all reusable workflows to have the correct tags. Pinning workflows to a branch (or leaving them unpinned) should be avoided from here on, only pin to tags.
The pin updating can be done on its own with `just pin-workflows {{ref}}`
Makes #67 unnecessary
commit 82828e9
Author: Andrew Cassidy <drewcassidy@me.com>
Date: Tue Oct 28 17:49:32 2025 -0700
Add note to the docs
commit f70929c
Author: Andrew Cassidy <drewcassidy@me.com>
Date: Tue Oct 28 17:41:19 2025 -0700
Only run checks for tag events
commit 108d8b8
Author: Andrew Cassidy <drewcassidy@me.com>
Date: Tue Oct 28 17:39:05 2025 -0700
Check for mismatches
this CI run should fail, I'll later restrict this check to only on tag pushes
commit bf2a436
Author: Andrew Cassidy <drewcassidy@me.com>
Date: Tue Oct 28 17:37:59 2025 -0700
Fix regex
commit adb4c77
Author: Andrew Cassidy <drewcassidy@me.com>
Date: Tue Oct 28 17:35:22 2025 -0700
Fix line endings
commit 0c99c7f
Author: Andrew Cassidy <drewcassidy@me.com>
Date: Tue Oct 28 17:21:15 2025 -0700
run yaclog via uv
this allows us to pin the version
commit 814ba63
Author: Andrew Cassidy <drewcassidy@me.com>
Date: Tue Oct 28 17:14:56 2025 -0700
Add tool to pin workflows while releasing a new version
(cherry picked from commit 09427ed)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If approved, reusable workflows would start printing a deprecation warning in the next version. Due to limitations of Github Actions, there's no way to pin a workflow's version and have that transitively pin the inner actions. So calling a workflow at 0.0.4 is still using actions from main. Alternatively the workflows would have to be manually updated with every update to use the current ref
I will also push a new commit for the last few tags that pins the actions those workflows use, so future action changes don't break anyone using past versions of the workflow