Skip to content

perf!: replace rayon with orx-parallel #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

perf!: replace rayon with orx-parallel #308

wants to merge 1 commit into from

Conversation

@KSXGitHub
Copy link
Owner

Resolves #305

TODO:

  • Restore the --threads.

@KSXGitHub KSXGitHub mentioned this pull request Aug 2, 2025
Closed
@KSXGitHub
Copy link
Owner Author

Experiment Results

Local measurement:

  • On small directory ($THIS_PROJECT/target), the rayon implementation is 20+ times faster than the orx-parallel implementation.
  • On big directory ($HOME), the orx-parallel implementation never stops. It is possible there was a deadlock of some kind.

CI: The orx-parallel implementation never stops.

Conclusion

This change is rejected.

@KSXGitHub KSXGitHub closed this Aug 2, 2025
@KSXGitHub KSXGitHub deleted the try-orx-parallel branch August 2, 2025 10:58
@KSXGitHub KSXGitHub mentioned this pull request Aug 2, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

perf: try orx-parallel

1 participant

@KSXGitHub