Skip to content

[PR] Fix: issue #57, add support for "Undecided" match results in outcome processing #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from
Open

[PR] Fix: issue #57, add support for "Undecided" match results in outcome processing #58

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
494a596
feat: add support for "Undecided" match results in outcome processing
scmisa Sep 9, 2025
0577f26
fix trailing whitespace
scmisa Sep 9, 2025
81757ac
Update src/sc2_datasets/transforms/mmr_vs_result.py
scmisa Sep 9, 2025
ce21306
Update src/sc2_datasets/transforms/pytorch/economy_vs_outcome.py
scmisa Sep 9, 2025
26aea81
feat: enhance result handling by including "Draw" and "Tie" outcomes
scmisa Sep 24, 2025
1f0c38b
feat: skip processing for "Undecided", "Draw", and "Tie" match result…
scmisa Sep 24, 2025
21933b0
refactor: format result_dict for consistency across outcome functions
scmisa Sep 24, 2025
78120cf
fix: return None for skipped replays in economy_average_vs_outcome fu…
scmisa Sep 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/sc2_datasets/transforms/mmr_vs_result.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,11 @@ def mmr_vs_result(sc2_replay: SC2ReplayData) -> Tuple[torch.Tensor, torch.Tensor
dtype=torch.float,
)

result_dict = {"Loss": 0, "Win": 1, "Victory": 1, "Defeat": 0}
result_dict = {"Loss": 0, "Win": 1, "Victory": 1, "Defeat": 0, "Undecided": -1}

# Check if result is "Undecided" and return None to skip this replay
if sc2_replay.toonPlayerDescMap[0].toon_player_info.result == "Undecided":
return None, None
label_tensor = torch.tensor(
result_dict[sc2_replay.toonPlayerDescMap[0].toon_player_info.result],
dtype=torch.int8,
Expand Down
7 changes: 6 additions & 1 deletion src/sc2_datasets/transforms/pytorch/economy_vs_outcome.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,12 @@ def economy_average_vs_outcome(
# Creating feature tensor:
feature_tensor = torch.tensor(feature_list, dtype=torch.float32)

result_dict = {"Loss": 0, "Win": 1, "Victory": 1, "Defeat": 0}
result_dict = {"Loss": 0, "Win": 1, "Victory": 1, "Defeat": 0, "Undecided": -1}

# Check if result is "Undecided" and return None to skip this replay
if sc2_replay.toonPlayerDescMap[0].toon_player_info.result == "Undecided":
return None, None

target = result_dict[sc2_replay.toonPlayerDescMap[0].toon_player_info.result]

return feature_tensor, target
8 changes: 7 additions & 1 deletion src/sc2_datasets/transforms/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,13 @@ def select_outcome_1v1(sc2_replay: SC2ReplayData) -> Dict[str, int]:

player_outcome = {"1": 0, "2": 0}

result_dict = {"Loss": 0, "Win": 1, "Victory": 1, "Defeat": 0}
result_dict = {"Loss": 0, "Win": 1, "Victory": 1, "Defeat": 0, "Undecided": -1}

# Check if any player has an "Undecided" result and return None to indicate skipping
for toon_desc_map in sc2_replay.toonPlayerDescMap:
if toon_desc_map.toon_player_info.result == "Undecided":
return None

for toon_desc_map in sc2_replay.toonPlayerDescMap:
result = result_dict[toon_desc_map.toon_player_info.result]
player_outcome[toon_desc_map.toon_player_info.playerID] = result
Expand Down
Loading