Skip to content

Use the latest actions/checkout version in GitHub Actions #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cooperwalbrun wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use the latest actions/checkout version in GitHub Actions #385

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ jobs:
name: Continuous integration
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v5
Copy link
Owner

@Keats Keats Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we pin by sha instead?

Copy link
Author

@cooperwalbrun cooperwalbrun Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can, but I am not sure why you would? Using the latest major like this is what GitHub themselves recommends.

Copy link
Owner

@Keats Keats Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this one is not really 3rd party but they do recommend to pin actions by sha: https://docs.github.com/en/actions/reference/security/secure-use#using-third-party-actions

Copy link
Author

@cooperwalbrun cooperwalbrun Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, the fact that it is more of a first-party action is why I did not think we needed to do it that way.

- name: Extract Rust version from Cargo.toml
run: |
MSRV=$(sed -n 's/^rust-version = "\([^"]*\)"/\1/p' Cargo.toml)
Expand Down Expand Up @@ -34,7 +34,7 @@ jobs:
include:
- rust: nightly
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v5
- name: Install Rust
uses: dtolnay/rust-toolchain@stable
with:
Expand Down