Replace defensive clear with assert in createImageViews

.gitignore

@@ -9,4 +9,6 @@ temp_ebook.md
 ebook/*.pdf
 ebook/*.epub
 
-convert.py
+convert.py
+
+attachments/build/

attachments/07_image_views.cpp

@@ -267,7 +267,7 @@ class HelloTriangleApplication {
     }
 
     void createImageViews() {
-        swapChainImageViews.clear();
+        assert(swapChainImageViews.empty());
 
         vk::ImageViewCreateInfo imageViewCreateInfo{ .viewType = vk::ImageViewType::e2D, .format = swapChainSurfaceFormat.format,
           .subresourceRange = { vk::ImageAspectFlagBits::eColor, 0, 1, 0, 1 } };

attachments/08_graphics_pipeline.cpp

@@ -268,7 +268,7 @@ class HelloTriangleApplication {
     }
 
     void createImageViews() {
-        swapChainImageViews.clear();
+        assert(swapChainImageViews.empty());
 
         vk::ImageViewCreateInfo imageViewCreateInfo{ .viewType = vk::ImageViewType::e2D, .format = swapChainSurfaceFormat.format,
           .subresourceRange = { vk::ImageAspectFlagBits::eColor, 0, 1, 0, 1 } };

attachments/09_shader_modules.cpp

@@ -269,7 +269,7 @@ class HelloTriangleApplication {
     }
 
     void createImageViews() {
-        swapChainImageViews.clear();
+        assert(swapChainImageViews.empty());
 
         vk::ImageViewCreateInfo imageViewCreateInfo{ .viewType = vk::ImageViewType::e2D, .format = swapChainSurfaceFormat.format,
           .subresourceRange = { vk::ImageAspectFlagBits::eColor, 0, 1, 0, 1 } };

attachments/10_fixed_functions.cpp

@@ -271,7 +271,7 @@ class HelloTriangleApplication {
     }
 
     void createImageViews() {
-        swapChainImageViews.clear();
+        assert(swapChainImageViews.empty());
 
         vk::ImageViewCreateInfo imageViewCreateInfo{ .viewType = vk::ImageViewType::e2D, .format = swapChainSurfaceFormat.format,
           .subresourceRange = { vk::ImageAspectFlagBits::eColor, 0, 1, 0, 1 } };

attachments/12_graphics_pipeline_complete.cpp

@@ -272,7 +272,7 @@ class HelloTriangleApplication {
     }
 
     void createImageViews() {
-        swapChainImageViews.clear();
+        assert(swapChainImageViews.empty());
 
         vk::ImageViewCreateInfo imageViewCreateInfo{ .viewType = vk::ImageViewType::e2D, .format = swapChainSurfaceFormat.format,
           .subresourceRange = { vk::ImageAspectFlagBits::eColor, 0, 1, 0, 1 } };

attachments/14_command_buffers.cpp

@@ -276,7 +276,7 @@ class HelloTriangleApplication {
     }
 
     void createImageViews() {
-        swapChainImageViews.clear();
+        assert(swapChainImageViews.empty());
 
         vk::ImageViewCreateInfo imageViewCreateInfo{ .viewType = vk::ImageViewType::e2D, .format = swapChainSurfaceFormat.format,
           .subresourceRange = { vk::ImageAspectFlagBits::eColor, 0, 1, 0, 1 } };

attachments/15_hello_triangle.cpp

@@ -285,7 +285,7 @@ class HelloTriangleApplication {
     }
 
     void createImageViews() {
-        swapChainImageViews.clear();
+        assert(swapChainImageViews.empty());
 
         vk::ImageViewCreateInfo imageViewCreateInfo{ .viewType = vk::ImageViewType::e2D, .format = swapChainSurfaceFormat.format,
           .subresourceRange = { vk::ImageAspectFlagBits::eColor, 0, 1, 0, 1 } };

attachments/16_frames_in_flight.cpp

@@ -289,7 +289,7 @@ class HelloTriangleApplication {
     }
 
     void createImageViews() {
-        swapChainImageViews.clear();
+        assert(swapChainImageViews.empty());
 
         vk::ImageViewCreateInfo imageViewCreateInfo{ .viewType = vk::ImageViewType::e2D, .format = swapChainSurfaceFormat.format,
           .subresourceRange = { vk::ImageAspectFlagBits::eColor, 0, 1, 0, 1 } };

attachments/17_swap_chain_recreation.cpp

@@ -316,7 +316,7 @@ class HelloTriangleApplication {
     }
 
     void createImageViews() {
-        swapChainImageViews.clear();
+        assert(swapChainImageViews.empty());
 
         vk::ImageViewCreateInfo imageViewCreateInfo{ .viewType = vk::ImageViewType::e2D, .format = swapChainSurfaceFormat.format,
           .subresourceRange = { vk::ImageAspectFlagBits::eColor, 0, 1, 0, 1 } };

attachments/18_vertex_input.cpp

@@ -340,7 +340,7 @@ class HelloTriangleApplication {
     }
 
     void createImageViews() {
-        swapChainImageViews.clear();
+        assert(swapChainImageViews.empty());
 
         vk::ImageViewCreateInfo imageViewCreateInfo{ .viewType = vk::ImageViewType::e2D, .format = swapChainSurfaceFormat.format,
           .subresourceRange = { vk::ImageAspectFlagBits::eColor, 0, 1, 0, 1 } };

attachments/19_vertex_buffer.cpp

@@ -344,6 +344,8 @@ class HelloTriangleApplication {
     }
 
     void createImageViews() {
+        assert(swapChainImageViews.empty());
+
         vk::ImageViewCreateInfo imageViewCreateInfo{ .viewType = vk::ImageViewType::e2D, .format = swapChainSurfaceFormat.format,
           .subresourceRange = { vk::ImageAspectFlagBits::eColor, 0, 1, 0, 1 } };
         for ( auto image : swapChainImages )

attachments/20_staging_buffer.cpp

@@ -344,6 +344,8 @@ class HelloTriangleApplication {
     }
 
     void createImageViews() {
+        assert(swapChainImageViews.empty());
+
         vk::ImageViewCreateInfo imageViewCreateInfo{ .viewType = vk::ImageViewType::e2D, .format = swapChainSurfaceFormat.format,
           .subresourceRange = { vk::ImageAspectFlagBits::eColor, 0, 1, 0, 1 } };
         for ( auto image : swapChainImages )

attachments/21_index_buffer.cpp

@@ -352,6 +352,8 @@ class HelloTriangleApplication {
     }
 
     void createImageViews() {
+        assert(swapChainImageViews.empty());
+
         vk::ImageViewCreateInfo imageViewCreateInfo{ .viewType = vk::ImageViewType::e2D, .format = swapChainSurfaceFormat.format,
           .subresourceRange = { vk::ImageAspectFlagBits::eColor, 0, 1, 0, 1 } };
         for ( auto image : swapChainImages )

attachments/22_descriptor_layout.cpp

@@ -369,6 +369,8 @@ class HelloTriangleApplication {
     }
 
     void createImageViews() {
+        assert(swapChainImageViews.empty());
+
         vk::ImageViewCreateInfo imageViewCreateInfo{ .viewType = vk::ImageViewType::e2D, .format = swapChainSurfaceFormat.format,
           .subresourceRange = { vk::ImageAspectFlagBits::eColor, 0, 1, 0, 1 } };
         for ( auto image : swapChainImages )

attachments/23_descriptor_sets.cpp

@@ -374,6 +374,8 @@ class HelloTriangleApplication {
     }
 
     void createImageViews() {
+        assert(swapChainImageViews.empty());
+
         vk::ImageViewCreateInfo imageViewCreateInfo{ .viewType = vk::ImageViewType::e2D, .format = swapChainSurfaceFormat.format,
           .subresourceRange = { vk::ImageAspectFlagBits::eColor, 0, 1, 0, 1 } };
         for ( auto image : swapChainImages )

attachments/24_texture_image.cpp

@@ -381,6 +381,8 @@ class HelloTriangleApplication {
     }
 
     void createImageViews() {
+        assert(swapChainImageViews.empty());
+
         vk::ImageViewCreateInfo imageViewCreateInfo{ .viewType = vk::ImageViewType::e2D, .format = swapChainSurfaceFormat.format,
           .subresourceRange = { vk::ImageAspectFlagBits::eColor, 0, 1, 0, 1 } };
         for ( auto image : swapChainImages )

attachments/25_sampler.cpp

@@ -386,6 +386,8 @@ class HelloTriangleApplication {
     }
 
     void createImageViews() {
+        assert(swapChainImageViews.empty());
+
         vk::ImageViewCreateInfo imageViewCreateInfo{ .viewType = vk::ImageViewType::e2D, .format = swapChainSurfaceFormat.format,
           .subresourceRange = { vk::ImageAspectFlagBits::eColor, 0, 1, 0, 1 } };
         for ( auto image : swapChainImages )

attachments/26_texture_mapping.cpp

@@ -388,6 +388,8 @@ class HelloTriangleApplication {
     }
 
     void createImageViews() {
+        assert(swapChainImageViews.empty());
+
         vk::ImageViewCreateInfo imageViewCreateInfo{ .viewType = vk::ImageViewType::e2D, .format = swapChainSurfaceFormat.format,
           .subresourceRange = { vk::ImageAspectFlagBits::eColor, 0, 1, 0, 1 } };
         for ( auto image : swapChainImages )

attachments/27_depth_buffering.cpp

@@ -401,6 +401,8 @@ class HelloTriangleApplication {
     }
 
     void createImageViews() {
+        assert(swapChainImageViews.empty());
+
         vk::ImageViewCreateInfo imageViewCreateInfo{
             .viewType = vk::ImageViewType::e2D,
             .format = swapChainSurfaceFormat.format,

attachments/28_model_loading.cpp

@@ -405,6 +405,8 @@ class HelloTriangleApplication {
     }
 
     void createImageViews() {
+        assert(swapChainImageViews.empty());
+
         vk::ImageViewCreateInfo imageViewCreateInfo{
             .viewType = vk::ImageViewType::e2D,
             .format = swapChainSurfaceFormat.format,

attachments/29_mipmapping.cpp

@@ -405,6 +405,8 @@ class HelloTriangleApplication {
     }
 
     void createImageViews() {
+        assert(swapChainImageViews.empty());
+
         vk::ImageViewCreateInfo imageViewCreateInfo{
             .viewType = vk::ImageViewType::e2D,
             .format = swapChainSurfaceFormat.format,

attachments/30_multisampling.cpp

@@ -414,6 +414,8 @@ class HelloTriangleApplication {
     }
 
     void createImageViews() {
+        assert(swapChainImageViews.empty());
+
         vk::ImageViewCreateInfo imageViewCreateInfo{
             .viewType = vk::ImageViewType::e2D,
             .format = swapChainSurfaceFormat.format,

attachments/31_compute_shader.cpp

@@ -393,6 +393,8 @@ class ComputeShaderApplication {
     }
 
     void createImageViews() {
+        assert(swapChainImageViews.empty());
+
         vk::ImageViewCreateInfo imageViewCreateInfo{
             .viewType = vk::ImageViewType::e2D,
             .format = swapChainSurfaceFormat.format,

attachments/32_ecosystem_utilities.cpp

@@ -517,6 +517,8 @@ class HelloTriangleApplication {
     }
 
     void createImageViews() {
+        assert(swapChainImageViews.empty());
+
         vk::ImageViewCreateInfo imageViewCreateInfo{
             .viewType = vk::ImageViewType::e2D,
             .format = swapChainSurfaceFormat.format,

attachments/33_vulkan_profiles.cpp

@@ -237,6 +237,7 @@ class HelloTriangleApplication {
             imageView = nullptr;
         }
 
+        swapChainImageViews.clear();
         swapChain = nullptr;
     }
 
@@ -493,6 +494,7 @@ class HelloTriangleApplication {
     }
 
     void createImageViews() {
+        assert(swapChainImageViews.empty());
         swapChainImageViews.reserve(swapChainImages.size());
 
         for (const auto& image : swapChainImages) {

attachments/34_android.cpp

@@ -612,6 +612,7 @@ class HelloTriangleApplication {
 
     // Create image views
     void createImageViews() {
+        assert(swapChainImageViews.empty());
         swapChainImageViews.reserve(swapChainImages.size());
 
         for (const auto& image : swapChainImages) {
@@ -1202,6 +1203,7 @@ class HelloTriangleApplication {
             imageView = nullptr;
         }
 
+        swapChainImageViews.clear();
         swapChain = nullptr;
     }
 

attachments/35_gltf_ktx.cpp

@@ -587,6 +587,8 @@ class VulkanApplication {
     }
 
     void createImageViews() {
+        assert(swapChainImageViews.empty());
+
         vk::ImageViewCreateInfo imageViewCreateInfo{
             .viewType = vk::ImageViewType::e2D,
             .format = swapChainSurfaceFormat.format,

attachments/36_multiple_objects.cpp

@@ -651,6 +651,8 @@ class VulkanApplication {
     }
 
     void createImageViews() {
+        assert(swapChainImageViews.empty());
+
         vk::ImageViewCreateInfo imageViewCreateInfo{
             .viewType = vk::ImageViewType::e2D,
             .format = swapChainSurfaceFormat.format,

attachments/37_multithreading.cpp

@@ -608,6 +608,8 @@ class MultithreadedApplication {
     }
 
     void createImageViews() {
+        assert(swapChainImageViews.empty());
+
         vk::ImageViewCreateInfo imageViewCreateInfo{
             .viewType = vk::ImageViewType::e2D,
             .format = swapChainSurfaceFormat.format,