Skip to content

Conversation

asuessenbach
Copy link
Contributor

In chapter 12 and following, a structure chain is manually created on creating the pipeline.

Should we change that to using a vk::StructureChain, instead?

Copy link
Collaborator

@SaschaWillems SaschaWillems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This improves readability by a lot!

So yes, I'm for doing it like this in all subsequent chapters.

@asuessenbach
Copy link
Contributor Author

Especially have a look at chapters 32 and 33, which need some special handling on the vk::StructureChain.

Note that some chapters have errors both with and without this PR:

  • 18, 22: validation layer errors, nothing is displayed
  • 26, 38: validation layer warnings
  • 35, 36: does not find some ktx.dll, exits

@SaschaWillems
Copy link
Collaborator

The issues with 35, 36 are prob. related to vcpkg. They work fine for me, but getting those to work on Windows was quite a hassle :/

@SaschaWillems
Copy link
Collaborator

Note that some chapters have errors both with and without this PR:

Last time I checked pretty much all chapters had validation errors, we need to tackle these, see #134

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants