Skip to content

Add exception handling for vk::SystemError #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Add exception handling for vk::SystemError #85

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f87c2d3
Add exception handling for vk::SystemError across mainLoop and presen…
gpx1000 Jul 5, 2025
58e0fe7
Merge branch 'upstream-main' into address-resize-issue-73
gpx1000 Aug 21, 2025
f474f04
Try to address resize issue in windows.
gpx1000 Aug 21, 2025
fb7a5c2
Refactor `drawFrame` error handling to simplify main loop and address…
gpx1000 Aug 22, 2025
e37bb22
Bring changes forward for resize.
gpx1000 Aug 22, 2025
284e1ec
Merge branch 'main' into address-resize-issue-73
gpx1000 Aug 23, 2025
914f3cb
Bring changes forward for resize.
gpx1000 Aug 23, 2025
040f4a5
Merge remote-tracking branch 'origin/address-resize-issue-73' into ad…
gpx1000 Aug 23, 2025
eede873
Recreate semaphores on swapchain resize and improve attachment transi…
gpx1000 Aug 23, 2025
6cf1473
Handle framebuffer resize with swapchain recreation
gpx1000 Aug 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion attachments/15_hello_triangle.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,18 @@ class HelloTriangleApplication {
void mainLoop() {
while (!glfwWindowShouldClose(window)) {
glfwPollEvents();
drawFrame();
try {
drawFrame();
} catch (const vk::SystemError& e) {
if (e.code().value() == static_cast<int>(vk::Result::eErrorOutOfDateKHR)) {
// Swapchain is out of date, this can happen during window close
// Just ignore and continue to close
std::cout << "Ignoring ErrorOutOfDateKHR during shutdown" << std::endl;
} else {
// Rethrow other errors
throw;
}
}
}

device.waitIdle();
Expand Down
13 changes: 12 additions & 1 deletion attachments/16_frames_in_flight.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,18 @@ class HelloTriangleApplication {
void mainLoop() {
while (!glfwWindowShouldClose(window)) {
glfwPollEvents();
drawFrame();
try {
drawFrame();
} catch (const vk::SystemError& e) {
if (e.code().value() == static_cast<int>(vk::Result::eErrorOutOfDateKHR)) {
// Swapchain is out of date, this can happen during window close
// Just ignore and continue to close
std::cout << "Ignoring ErrorOutOfDateKHR during shutdown" << std::endl;
} else {
// Rethrow other errors
throw;
}
}
}

device.waitIdle();
Expand Down
40 changes: 31 additions & 9 deletions attachments/17_swap_chain_recreation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,18 @@ class HelloTriangleApplication {
void mainLoop() {
while (!glfwWindowShouldClose(window)) {
glfwPollEvents();
drawFrame();
try {
drawFrame();
} catch (const vk::SystemError& e) {
if (e.code().value() == static_cast<int>(vk::Result::eErrorOutOfDateKHR)) {
// Swapchain is out of date, this can happen during window close
// Just ignore and continue to close
std::cout << "Ignoring ErrorOutOfDateKHR during shutdown" << std::endl;
} else {
// Rethrow other errors
throw;
}
}
}

device.waitIdle();
Expand Down Expand Up @@ -535,14 +546,25 @@ class HelloTriangleApplication {
graphicsQueue.submit(submitInfo, *inFlightFences[currentFrame]);


const vk::PresentInfoKHR presentInfoKHR{ .waitSemaphoreCount = 1, .pWaitSemaphores = &*renderFinishedSemaphore[imageIndex],
.swapchainCount = 1, .pSwapchains = &*swapChain, .pImageIndices = &imageIndex };
result = presentQueue.presentKHR( presentInfoKHR );
if (result == vk::Result::eErrorOutOfDateKHR || result == vk::Result::eSuboptimalKHR || framebufferResized) {
framebufferResized = false;
recreateSwapChain();
} else if (result != vk::Result::eSuccess) {
throw std::runtime_error("failed to present swap chain image!");
try {
const vk::PresentInfoKHR presentInfoKHR{ .waitSemaphoreCount = 1, .pWaitSemaphores = &*renderFinishedSemaphore[imageIndex],
.swapchainCount = 1, .pSwapchains = &*swapChain, .pImageIndices = &imageIndex };
result = presentQueue.presentKHR( presentInfoKHR );
if (result == vk::Result::eErrorOutOfDateKHR || result == vk::Result::eSuboptimalKHR || framebufferResized) {
framebufferResized = false;
recreateSwapChain();
} else if (result != vk::Result::eSuccess) {
throw std::runtime_error("failed to present swap chain image!");
}
} catch (const vk::SystemError& e) {
if (e.code().value() == static_cast<int>(vk::Result::eErrorOutOfDateKHR)) {
// Swapchain is out of date, this can happen during window close
// Just ignore and continue to close
std::cout << "Ignoring ErrorOutOfDateKHR during presentation" << std::endl;
} else {
// Rethrow other errors
throw;
}
}
semaphoreIndex = (semaphoreIndex + 1) % presentCompleteSemaphore.size();
currentFrame = (currentFrame + 1) % MAX_FRAMES_IN_FLIGHT;
Expand Down
40 changes: 31 additions & 9 deletions attachments/18_vertex_input.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,18 @@ class HelloTriangleApplication {
void mainLoop() {
while (!glfwWindowShouldClose(window)) {
glfwPollEvents();
drawFrame();
try {
drawFrame();
} catch (const vk::SystemError& e) {
if (e.code().value() == static_cast<int>(vk::Result::eErrorOutOfDateKHR)) {
// Swapchain is out of date, this can happen during window close
// Just ignore and continue to close
std::cout << "Ignoring ErrorOutOfDateKHR during shutdown" << std::endl;
} else {
// Rethrow other errors
throw;
}
}
}

device.waitIdle();
Expand Down Expand Up @@ -562,14 +573,25 @@ class HelloTriangleApplication {
graphicsQueue.submit(submitInfo, *inFlightFences[currentFrame]);


const vk::PresentInfoKHR presentInfoKHR{ .waitSemaphoreCount = 1, .pWaitSemaphores = &*renderFinishedSemaphore[imageIndex],
.swapchainCount = 1, .pSwapchains = &*swapChain, .pImageIndices = &imageIndex };
result = presentQueue.presentKHR( presentInfoKHR );
if (result == vk::Result::eErrorOutOfDateKHR || result == vk::Result::eSuboptimalKHR || framebufferResized) {
framebufferResized = false;
recreateSwapChain();
} else if (result != vk::Result::eSuccess) {
throw std::runtime_error("failed to present swap chain image!");
try {
const vk::PresentInfoKHR presentInfoKHR{ .waitSemaphoreCount = 1, .pWaitSemaphores = &*renderFinishedSemaphore[imageIndex],
.swapchainCount = 1, .pSwapchains = &*swapChain, .pImageIndices = &imageIndex };
result = presentQueue.presentKHR( presentInfoKHR );
if (result == vk::Result::eErrorOutOfDateKHR || result == vk::Result::eSuboptimalKHR || framebufferResized) {
framebufferResized = false;
recreateSwapChain();
} else if (result != vk::Result::eSuccess) {
throw std::runtime_error("failed to present swap chain image!");
}
} catch (const vk::SystemError& e) {
if (e.code().value() == static_cast<int>(vk::Result::eErrorOutOfDateKHR)) {
// Swapchain is out of date, this can happen during window close
// Just ignore and continue to close
std::cout << "Ignoring ErrorOutOfDateKHR during presentation" << std::endl;
} else {
// Rethrow other errors
throw;
}
}
semaphoreIndex = (semaphoreIndex + 1) % presentCompleteSemaphore.size();
currentFrame = (currentFrame + 1) % MAX_FRAMES_IN_FLIGHT;
Expand Down
40 changes: 31 additions & 9 deletions attachments/19_vertex_buffer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,18 @@ class HelloTriangleApplication {
void mainLoop() {
while (!glfwWindowShouldClose(window)) {
glfwPollEvents();
drawFrame();
try {
drawFrame();
} catch (const vk::SystemError& e) {
if (e.code().value() == static_cast<int>(vk::Result::eErrorOutOfDateKHR)) {
// Swapchain is out of date, this can happen during window close
// Just ignore and continue to close
std::cout << "Ignoring ErrorOutOfDateKHR during shutdown" << std::endl;
} else {
// Rethrow other errors
throw;
}
}
}

device.waitIdle();
Expand Down Expand Up @@ -592,14 +603,25 @@ class HelloTriangleApplication {
graphicsQueue.submit(submitInfo, *inFlightFences[currentFrame]);


const vk::PresentInfoKHR presentInfoKHR{ .waitSemaphoreCount = 1, .pWaitSemaphores = &*renderFinishedSemaphore[imageIndex],
.swapchainCount = 1, .pSwapchains = &*swapChain, .pImageIndices = &imageIndex };
result = presentQueue.presentKHR( presentInfoKHR );
if (result == vk::Result::eErrorOutOfDateKHR || result == vk::Result::eSuboptimalKHR || framebufferResized) {
framebufferResized = false;
recreateSwapChain();
} else if (result != vk::Result::eSuccess) {
throw std::runtime_error("failed to present swap chain image!");
try {
const vk::PresentInfoKHR presentInfoKHR{ .waitSemaphoreCount = 1, .pWaitSemaphores = &*renderFinishedSemaphore[imageIndex],
.swapchainCount = 1, .pSwapchains = &*swapChain, .pImageIndices = &imageIndex };
result = presentQueue.presentKHR( presentInfoKHR );
if (result == vk::Result::eErrorOutOfDateKHR || result == vk::Result::eSuboptimalKHR || framebufferResized) {
framebufferResized = false;
recreateSwapChain();
} else if (result != vk::Result::eSuccess) {
throw std::runtime_error("failed to present swap chain image!");
}
} catch (const vk::SystemError& e) {
if (e.code().value() == static_cast<int>(vk::Result::eErrorOutOfDateKHR)) {
// Swapchain is out of date, this can happen during window close
// Just ignore and continue to close
std::cout << "Ignoring ErrorOutOfDateKHR during presentation" << std::endl;
} else {
// Rethrow other errors
throw;
}
}
semaphoreIndex = (semaphoreIndex + 1) % presentCompleteSemaphore.size();
currentFrame = (currentFrame + 1) % MAX_FRAMES_IN_FLIGHT;
Expand Down
40 changes: 31 additions & 9 deletions attachments/20_staging_buffer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,18 @@ class HelloTriangleApplication {
void mainLoop() {
while (!glfwWindowShouldClose(window)) {
glfwPollEvents();
drawFrame();
try {
drawFrame();
} catch (const vk::SystemError& e) {
if (e.code().value() == static_cast<int>(vk::Result::eErrorOutOfDateKHR)) {
// Swapchain is out of date, this can happen during window close
// Just ignore and continue to close
std::cout << "Ignoring ErrorOutOfDateKHR during shutdown" << std::endl;
} else {
// Rethrow other errors
throw;
}
}
}

device.waitIdle();
Expand Down Expand Up @@ -611,14 +622,25 @@ class HelloTriangleApplication {
graphicsQueue.submit(submitInfo, *inFlightFences[currentFrame]);


const vk::PresentInfoKHR presentInfoKHR{ .waitSemaphoreCount = 1, .pWaitSemaphores = &*renderFinishedSemaphore[imageIndex],
.swapchainCount = 1, .pSwapchains = &*swapChain, .pImageIndices = &imageIndex };
result = presentQueue.presentKHR( presentInfoKHR );
if (result == vk::Result::eErrorOutOfDateKHR || result == vk::Result::eSuboptimalKHR || framebufferResized) {
framebufferResized = false;
recreateSwapChain();
} else if (result != vk::Result::eSuccess) {
throw std::runtime_error("failed to present swap chain image!");
try {
const vk::PresentInfoKHR presentInfoKHR{ .waitSemaphoreCount = 1, .pWaitSemaphores = &*renderFinishedSemaphore[imageIndex],
.swapchainCount = 1, .pSwapchains = &*swapChain, .pImageIndices = &imageIndex };
result = presentQueue.presentKHR( presentInfoKHR );
if (result == vk::Result::eErrorOutOfDateKHR || result == vk::Result::eSuboptimalKHR || framebufferResized) {
framebufferResized = false;
recreateSwapChain();
} else if (result != vk::Result::eSuccess) {
throw std::runtime_error("failed to present swap chain image!");
}
} catch (const vk::SystemError& e) {
if (e.code().value() == static_cast<int>(vk::Result::eErrorOutOfDateKHR)) {
// Swapchain is out of date, this can happen during window close
// Just ignore and continue to close
std::cout << "Ignoring ErrorOutOfDateKHR during presentation" << std::endl;
} else {
// Rethrow other errors
throw;
}
}
semaphoreIndex = (semaphoreIndex + 1) % presentCompleteSemaphore.size();
currentFrame = (currentFrame + 1) % MAX_FRAMES_IN_FLIGHT;
Expand Down
13 changes: 12 additions & 1 deletion attachments/21_index_buffer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,18 @@ class HelloTriangleApplication {
void mainLoop() {
while (!glfwWindowShouldClose(window)) {
glfwPollEvents();
drawFrame();
try {
drawFrame();
} catch (const vk::SystemError& e) {
if (e.code().value() == static_cast<int>(vk::Result::eErrorOutOfDateKHR)) {
// Swapchain is out of date, this can happen during window close
// Just ignore and continue to close
std::cout << "Ignoring ErrorOutOfDateKHR during shutdown" << std::endl;
} else {
// Rethrow other errors
throw;
}
}
}

device.waitIdle();
Expand Down
13 changes: 12 additions & 1 deletion attachments/22_descriptor_layout.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,18 @@ class HelloTriangleApplication {
void mainLoop() {
while (!glfwWindowShouldClose(window)) {
glfwPollEvents();
drawFrame();
try {
drawFrame();
} catch (const vk::SystemError& e) {
if (e.code().value() == static_cast<int>(vk::Result::eErrorOutOfDateKHR)) {
// Swapchain is out of date, this can happen during window close
// Just ignore and continue to close
std::cout << "Ignoring ErrorOutOfDateKHR during shutdown" << std::endl;
} else {
// Rethrow other errors
throw;
}
}
}

device.waitIdle();
Expand Down
13 changes: 12 additions & 1 deletion attachments/23_descriptor_sets.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,18 @@ class HelloTriangleApplication {
void mainLoop() {
while (!glfwWindowShouldClose(window)) {
glfwPollEvents();
drawFrame();
try {
drawFrame();
} catch (const vk::SystemError& e) {
if (e.code().value() == static_cast<int>(vk::Result::eErrorOutOfDateKHR)) {
// Swapchain is out of date, this can happen during window close
// Just ignore and continue to close
std::cout << "Ignoring ErrorOutOfDateKHR during shutdown" << std::endl;
} else {
// Rethrow other errors
throw;
}
}
}

device.waitIdle();
Expand Down
13 changes: 12 additions & 1 deletion attachments/24_texture_image.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,18 @@ class HelloTriangleApplication {
void mainLoop() {
while (!glfwWindowShouldClose(window)) {
glfwPollEvents();
drawFrame();
try {
drawFrame();
} catch (const vk::SystemError& e) {
if (e.code().value() == static_cast<int>(vk::Result::eErrorOutOfDateKHR)) {
// Swapchain is out of date, this can happen during window close
// Just ignore and continue to close
std::cout << "Ignoring ErrorOutOfDateKHR during shutdown" << std::endl;
} else {
// Rethrow other errors
throw;
}
}
}

device.waitIdle();
Expand Down
13 changes: 12 additions & 1 deletion attachments/25_sampler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,18 @@ class HelloTriangleApplication {
void mainLoop() {
while (!glfwWindowShouldClose(window)) {
glfwPollEvents();
drawFrame();
try {
drawFrame();
} catch (const vk::SystemError& e) {
if (e.code().value() == static_cast<int>(vk::Result::eErrorOutOfDateKHR)) {
// Swapchain is out of date, this can happen during window close
// Just ignore and continue to close
std::cout << "Ignoring ErrorOutOfDateKHR during shutdown" << std::endl;
} else {
// Rethrow other errors
throw;
}
}
}

device.waitIdle();
Expand Down
27 changes: 19 additions & 8 deletions attachments/26_texture_mapping.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -931,14 +931,25 @@ class HelloTriangleApplication {
graphicsQueue.submit(submitInfo, *inFlightFences[currentFrame]);


const vk::PresentInfoKHR presentInfoKHR{ .waitSemaphoreCount = 1, .pWaitSemaphores = &*renderFinishedSemaphore[imageIndex],
.swapchainCount = 1, .pSwapchains = &*swapChain, .pImageIndices = &imageIndex };
result = presentQueue.presentKHR(presentInfoKHR);
if (result == vk::Result::eErrorOutOfDateKHR || result == vk::Result::eSuboptimalKHR || framebufferResized) {
framebufferResized = false;
recreateSwapChain();
} else if (result != vk::Result::eSuccess) {
throw std::runtime_error("failed to present swap chain image!");
try {
const vk::PresentInfoKHR presentInfoKHR{ .waitSemaphoreCount = 1, .pWaitSemaphores = &*renderFinishedSemaphore[imageIndex],
.swapchainCount = 1, .pSwapchains = &*swapChain, .pImageIndices = &imageIndex };
result = presentQueue.presentKHR(presentInfoKHR);
if (result == vk::Result::eErrorOutOfDateKHR || result == vk::Result::eSuboptimalKHR || framebufferResized) {
framebufferResized = false;
recreateSwapChain();
} else if (result != vk::Result::eSuccess) {
throw std::runtime_error("failed to present swap chain image!");
}
} catch (const vk::SystemError& e) {
if (e.code().value() == static_cast<int>(vk::Result::eErrorOutOfDateKHR)) {
// Swapchain is out of date, this can happen during window close
// Just ignore and continue to close
std::cout << "Ignoring ErrorOutOfDateKHR during presentation" << std::endl;
} else {
// Rethrow other errors
throw;
}
}
semaphoreIndex = (semaphoreIndex + 1) % presentCompleteSemaphore.size();
currentFrame = (currentFrame + 1) % MAX_FRAMES_IN_FLIGHT;
Expand Down
Loading
Loading