feat(ui):Add max cost auto-approval setting similar to max requests #1271
+1,011
−80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hassoncs
force-pushed
the
add-max-costs-to-approval-settings
branch
from
5188ed1 to
f59c0d7
Compare
hassoncs
force-pushed
the
add-max-cost-limit
branch
5 times, most recently
from
ef2d4cc to
230a9e0
Compare
hassoncs
force-pushed
the
add-max-cost-limit
branch
from
7e6ba04 to
22ebf4e
Compare
hassoncs
force-pushed
the
add-max-cost-limit
branch
2 times, most recently
from
9a86012 to
f954f97
Compare
hassoncs
force-pushed
the
storybook-theme-colors
branch
2 times, most recently
from
ee1af7a to
4d44377
Compare
hassoncs
force-pushed
the
add-max-cost-limit
branch
from
f954f97 to
0cb992b
Compare
hassoncs
force-pushed
the
storybook-theme-colors
branch
from
4d44377 to
978cccf
Compare
added 6 commits
July 30, 2025 13:49
Introduces a new `DecoratedVSCodeTextField` component that wraps the standard VSCode text field and allows for the addition of left and right nodes (e.g., icons, currency symbols). This enhances the flexibility and visual presentation of text input fields within the UI. The component includes: - Support for `leftNodes` and `rightNodes` to display content inside the text field. - Automatic padding adjustment based on the presence of nodes. - Storybook stories demonstrating various use cases (price input, search input). - Unit tests to ensure proper rendering and functionality of the component with and without nodes.
This commit introduces a new auto-approval setting that allows users to define a maximum API cost. The system will automatically approve requests up to this cost limit before prompting the user for approval to continue the task. Key changes include: - Added `allowedMaxCost` to `globalSettingsSchema` in `@packages/types`. - Implemented cost tracking and limit enforcement in `Task.ts`. - Integrated `allowedMaxCost` into `ClineProvider` and `webviewMessageHandler` for state management. - Created new UI components `CostInput`, `FormattedTextField`, and `MaxLimitInputs` in `webview-ui` to handle cost input and formatting. - Updated `AutoApproveMenu` and `AutoApproveSettings` to include the new cost limit input. - Added new Storybook stories for `AutoApproveMenu` and `AutoApproveSettings`. - Included new test files for `FormattedTextField` and `MaxCostInput`. - Updated i18n localization files across all supported languages to include new strings for the API cost limit setting.
Refactors `DecoratedVSCodeTextField` to extend `ComponentProps<typeof VSCodeTextField>`, removing redundant prop definitions and simplifying its interface. This change improves maintainability and ensures consistency with the underlying VSCode text field component. Also adjusts `FormattedTextField` to correctly forward refs with the updated prop types.
Removed redundant description props from MaxCostInput and MaxRequestsInput components. The common description for both API limits is now handled in MaxLimitInputs, improving consistency and reducing duplication across i18n files.
This commit enhances the auto-approval warning system to distinguish between reaching the request limit and the cost limit. - **`src/core/task/Task.ts`**: Modified to pass a `type` parameter (`"requests"` or `"cost"`) to the `ask` method when the auto-approval limit is reached. - **`webview-ui/src/components/chat/AutoApprovedRequestLimitWarning.tsx`**: Updated to use the new `type` parameter to dynamically select appropriate i18n keys for title, description, and button text, providing clearer messages to the user. - **`webview-ui/src/components/settings/MaxCostInput.tsx`**: Refactored to use a new `FormattedTextField` component, simplifying input handling and validation for the max cost setting. This change removes redundant state management and event handlers. - **`webview-ui/src/components/settings/__tests__/MaxCostInput.spec.tsx`**: Updated tests to reflect the changes in `MaxCostInput`, specifically removing tests related to blur/enter events and focusing on direct value changes. - **`webview-ui/src/i18n/locales/*/chat.json`**: Added new translation keys (`autoApprovedCostLimitReached.title`, `description`, `button`) across all supported languages to support the cost limit warning. This change improves user clarity and experience by providing specific feedback when either the request count or the monetary cost limit for auto-approved actions is reached.
hassoncs
force-pushed
the
add-max-cost-limit
branch
2 times, most recently
from
06ea770 to
aa58ea4
Compare
Introduces the `allowedMaxCost` setting to control the maximum cost allowed for auto-approved requests. This change includes: - Adding `allowedMaxCost` to `GlobalSettingsSchema`, `ExtensionState`, and `WebviewMessage` types. - Updating `Task.ts` to track `consecutiveAutoApprovedCost`. - Modifying `ClineProvider.ts` to handle `allowedMaxCost` in state management. - Updating `webviewMessageHandler.ts` to process `allowedMaxCost` messages. - Creating new UI components `MaxCostInput.tsx` and `MaxLimitInputs.tsx` for the setting. - Enhancing `FormattedTextField.tsx` with `unlimitedDecimalFormatter` for cost input. - Updating `AutoApproveMenu.tsx` and `SettingsView.tsx` to integrate the new cost limit input. - Adjusting `AutoApprovedRequestLimitWarning.tsx` to differentiate between request and cost limits. - Adding `kilocode_change` markers where necessary for upstream compatibility.
hassoncs
force-pushed
the
add-max-cost-limit
branch
from
aa58ea4 to
dd700ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new Max cost field similar to the 'max request count' field we already have.