-
Notifications
You must be signed in to change notification settings - Fork 926
Adding MakeHub, the smart router for AI coding assistant #631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR integrates MakeHub as a new AI provider into Kilocode to deliver consistent performance, reduced latency, and cost-effective access across various models. The changes include the addition of MakeHub-specific configuration options and UI components, updates to model fetching and API handling, and modifications to type definitions and provider schemas.
Reviewed Changes
Copilot reviewed 40 out of 40 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
webview-ui/src/components/ui/hooks/useSelectedModel.ts | Added support for MakeHub in model selection logic. |
webview-ui/src/components/settings/providers/MakeHub.tsx | Introduced a new settings component for configuring MakeHub. |
webview-ui/src/components/settings/ApiOptions.tsx | Included MakeHub in provider switch-case and configuration defaults. |
src/shared/api.ts, ProfileValidator.ts, and others | Updated provider lists and type definitions to include MakeHub. |
src/api/providers/makehub.ts | New API handler for MakeHub with cost calculation and message streaming. |
src/api/providers/fetchers/makehub.ts | New model fetcher for MakeHub integrating API response parsing. |
packages/types and evals packages | Updated type definitions and provider schemas for MakeHub. |
Comments suppressed due to low confidence (1)
src/api/providers/makehub.ts:1
- The import of 'Anthropic' is unused in this file. Removing it may improve code clarity.
import { Anthropic } from "@anthropic-ai/sdk"
Hello, I’ve implemented the needed corrections and pushed the updates. Best, |
Hi, I have added Makehub to the necessary test files. Best |
Hello, I have update the PR to the lastest commits. Best, |
3833d0d
to
90bfa1d
Compare
I’ve updated the PR with the latest changes and squashed all commits into one for a cleaner history. Let me know if anything else is needed! |
c80181c
to
61d4242
Compare
Hello @Juice10, I’ve updated the PR with the latest changes and squashed all commits into one for a cleaner history. Let me know if anything else is needed. Best, |
70b5eb6
to
713af94
Compare
Thank you for the review! However, I see that all the tests passed except for Chromatic Visual Testing /chromatic (pull_request). It looks like there’s no Chromatic token set on your GitHub repository, which I think needs to be configured on your end. I set up the token in my fork, and Chromatic worked fine there. Please let me know if there’s anything else you’d like me to do. Best regards. |
Hi @ffp5! Thanks for the contribution and apologies for the delay in processing this PR! We added the Chromatic job recently and indeed seems like it doesn't work for community contributed PR's right now but that's fully our problem that we need to fix so don't worry about it. Not your issue at all! There's a couple of merge conflicts right now due to updates. Any chance you could look into those still? Also, am I right in my assertion that you are working for MakeHub and trying to land support because of this? We're ok with that but would be nice to have some clarity on that topic. |
713af94
to
26b6940
Compare
Hi @kevinvandijk , Of course, I’ve just updated the PR to include the latest commits. Let me know if there’s anything else I can do on my end. Best, |
af2f333
to
2f21d29
Compare
49624a1
to
b3b09ad
Compare
Hi @kevinvandijk , Of course, I’ve just updated the PR to include the latest commits. |
cb01bd3
to
9b44acf
Compare
Hi @kevinvandijk , I’ve just updated the PR to include the latest commits. Best, |
b28bf7a
to
94375a9
Compare
Context
As daily users of Kilocode, my team and I frequently encounter rate limits and performance inconsistencies when using certain AI providers. These limitations hinder our development workflow, especially when leveraging advanced models. We seek a solution that offers:
-consistent performance
-reduced latency
-cost-effective access to various AI models
-A Solution for Developers by Developers.
So, We propose integrating MakeHub.ai as an AI provider within Kilocode. MakeHub.ai offers a high-speed LLM API that performs real-time speed and price arbitrage across multiple providers for close and open source models. Users can define performance parameters such as speed and price, allowing MakeHub to select the most cost-effective provider that meets these requirements. This integration would enable developers to experience consistent performance and pricing across various models, all through a single API key.
Implementation
Some description of HOW you achieved it. Perhaps give a high level description of the program flow. Did you need to refactor something? What tradeoffs did you take? Are there things in here which you’d particularly like people to pay close attention to?
We’ve followed Kilocode’s current pattern for adding providers. Since MakeHub is OpenAI API compatible (including chat/completions/embeddings endpoints), integration required no major refactor. Also, we add MakeHub in the necessary tests.
Screenshots
How to Test
A straightforward scenario of how to test your changes will help reviewers that are not familiar with the part of the code that you are changing but want to see it in action. This section can include a description or step-by-step instructions of how to get to the state of v2 that your change affects.
Get in Touch
We'd love to have a way to chat with you about your changes if necessary. If you're in the Kilo Code Discord, please share your handle here. -->
We’d love to discuss this integration further and hear your feedback.
We’re on the Kilocode Discord: