refactor: remove `ScalarExpression::Position` #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

KKould merged 1 commit into main from refactor/remove_position_expr

Sep 21, 2025

Member

KKould commented Sep 21, 2025

What problem does this PR solve?

Removed ScalarExpress::Position, forcing all expressions to be bound to position

Code changes

Has Rust code change
Has CI related scripts change

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Note for reviewer


          refactor: remove ScalarExpression::Position

9a8a482

KKould self-assigned this

KKould added the enhancement label

KKould merged commit f1215c6 into main

6 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels