rft(snap): Conditionally check for snap packages #795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* In the event that the snapd service is not running, the snap client can spend a large amount of time trying to connect to it and ultimately failing. The expectation is that since snap comes already installed in several linux distros that the socket is placed in the same place. ```bash $ # with the check $ time ./screenfetch-dev real 0m0.680s user 0m0.389s sys 0m0.260s $ # without the check $ time screenfetch real 2m0.908s user 0m0.632s sys 0m0.501s ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alternative fix to #740