Dev/improve configurable documentation #406
Conversation
Purg
left a comment
Purg
left a comment
There was a problem hiding this comment.
Some capitalization for consistency and an import issue as interpreted from the doc-test perspective.
Purg
left a comment
Purg
left a comment
There was a problem hiding this comment.
Python 2.7 unit test issue. Yes yes, python 2 is deprecated, but I'm not sure its appropriate to fully deprecate tests just yet. Also that would be a different PR.
Purg
left a comment
Purg
left a comment
There was a problem hiding this comment.
Not sure why travis-ci results are not showing readilly in the review section at the bottom, but that's still failing if you go to https://travis-ci.org/github/Kitware/SMQTK/ and then find your branch in there. TLDR there's a missing line-continuation in the doc-test.
It may be helpful to run pytest or setup.py test locally to make sure things pass and then use CI as a double check.
| >>> NonCompliantDefault.get_default_config() == | ||
| ... {'power_func': {'module': 'math', 'attribute': 'pow'}} |
There was a problem hiding this comment.
Failing doc-test: requires a slash at the end for the line continuation.
| >>> NonCompliantDefault.get_default_config() == | |
| ... {'power_func': {'module': 'math', 'attribute': 'pow'}} | |
| >>> NonCompliantDefault.get_default_config() == \ | |
| ... {'power_func': {'module': 'math', 'attribute': 'pow'}} |
| >>> json.dumps(NonCompliantDefault.get_default_config()) == | ||
| ... {"power_func": {"module": "math", "attribute": "pow"}} |
There was a problem hiding this comment.
Failing doc-test: requires a slash at the end for the line continuation.
| >>> json.dumps(NonCompliantDefault.get_default_config()) == | |
| ... {"power_func": {"module": "math", "attribute": "pow"}} | |
| >>> json.dumps(NonCompliantDefault.get_default_config()) == \ | |
| ... {"power_func": {"module": "math", "attribute": "pow"}} |
2 participants
No description provided.