refactor(bounds): fix getBounds to return a copy of model.bounds #3321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
finetjul
force-pushed
the
fixup-bounds
branch
3 times, most recently
from
a59ca81 to
36385e0
Compare
A getter should return a copy and not a reference. getBoundsByReference can return the actual model.bounds array. BREAKING CHANGE: Mappers should overwrite computeBounds instead of getBounds
finetjul
force-pushed
the
fixup-bounds
branch
from
36385e0 to
de6821e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A getter should return a copy and not a reference. getBoundsByReference can return the actual model.bounds array.
BREAKING CHANGE: Mappers should overwrite computeBounds instead of getBounds