Enable default template hierarchy #164
Conversation
| if (HostManager.host == KonanTarget.MACOS_X64.INSTANCE) macosX64('konan') | ||
| if (HostManager.host == KonanTarget.MACOS_ARM64.INSTANCE) macosArm64('konan') | ||
| if (HostManager.hostIsLinux) linuxX64('konan') | ||
| if (HostManager.hostIsMingw) mingwX64('konan') |
There was a problem hiding this comment.
Perhaps we can now just declare all these targets, no matter what the current host is.
There was a problem hiding this comment.
This is a viable option. The only downside is the dangling benchmark tasks that do nothing in a particular host.
There was a problem hiding this comment.
Since this is an example, it should be similar to how user multiplatform projects are set up, and they definitely do not use this trick with HostManager anymore.
There was a problem hiding this comment.
Done.
By the way, it turns out the plugin does not create benchmark tasks for non-host targets. It just reports that benchmarks for those targets cannot be run in current host, e.g.:
Skipping benchmarks for 'linuxX64' because they cannot be run on current OS: Expected macos_x64, but was linux_x64
So the situation is better.
| linuxX64() | ||
| mingwX64() | ||
|
|
||
| applyDefaultHierarchyTemplate() |
There was a problem hiding this comment.
I believe we should strive that the project contains no custom dependsOn so that the template is applied automatically.
qurbonzoda
force-pushed
the
qurbonzoda/enable-default-template-hierarchy
branch
from
0152cb5 to
bf8df6c
Compare
qurbonzoda
changed the base branch from
qurbonzoda/support-Kotlin-1.9.20
to
master
…lin#164) Bumps [org.apache.maven.plugins:maven-compiler-plugin](https://github.com/apache/maven-compiler-plugin) from 3.11.0 to 3.12.0. - [Release notes](https://github.com/apache/maven-compiler-plugin/releases) - [Commits](apache/maven-compiler-plugin@maven-compiler-plugin-3.11.0...maven-compiler-plugin-3.12.0) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-compiler-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Followup to #163