Fix various warnings and cleanup samples #579
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Applied every IDE suggestion to the samples. We should keep the sample code copy-pasteable into the IDE without warnings. * Gradle mentions that compileOnly dependencies don't work in Wasm, so changed the dependency of `kotlinx-datetime-zoneinfo` from compileOnly to api. * Replaced the non-exhaustive-when error suppressions with a runtime check to be able to diagnose the issue better if we indeed make an error at some point. The runtime check can be removed if the compiler becomes smarter. * Fixed various other warnings both in test/ and src/.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kotlinx-datetime-zoneinfofrom compileOnly to api.