Fix a flaky check and a TSan violation in StateFlowStressTest.
#4483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess if you want to check that none of the collectors "hanged up" then you could check that |
|
Yes, good idea. Could you please add that check? |
chaoren
force-pushed
the
StateFlowStressTest
branch
from
e0cf96d to
c0f5474
Compare
chaoren
changed the title
StateFlowStressTest.StateFlowStressTest.
|
Done. I noticed that the relative values between different emitters doesn't actually matter. They can each emit values at an arbitrary pace, so it doesn't make sense to use |
chaoren
force-pushed
the
StateFlowStressTest
branch
from
c0f5474 to
997cdcf
Compare
chaoren
changed the title
StateFlowStressTest.StateFlowStressTest and a TSan violation.
chaoren
force-pushed
the
StateFlowStressTest
branch
from
997cdcf to
e50f612
Compare
chaoren
changed the title
StateFlowStressTest and a TSan violation.StateFlowStressTest.
There's no guarantee that any particular collector will ever encounter a value emitted by a particular emitter. It's entirely possible for the value to be overwritten by a different emitter before the collector gets a chance to collect it. It's very unlikely for a collector to miss the second half of all values emitted by a particular emitter, but it is still possible and this causes the test to be flaky. We can instead check if the collector has collected a recent enough value from *any* emitter. This should be sufficient to verify that the collector was still running near the end of the test. Also fixed a race condition in the test when printing test progress. The race condition is benign, but it causes TSan to fail for the test, which could prevent it from finding other concurrency bugs.
chaoren
force-pushed
the
StateFlowStressTest
branch
from
e50f612 to
3527031
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no guarantee that any particular collector will ever encounter a value emitted by a particular emitter. It's entirely possible for the value to be overwritten by a different emitter before the collector gets a chance to collect it. It's very unlikely for a collector to miss the second half of all values emitted by a particular emitter, but it is still possible and this causes the test to be flaky.