Depend on root components instead of platform-specific components #4536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "-js" dependencies are an uncoventional way to specify dependencies and these dependencies are problematic for testing lenient KMP resolution.
|
I decided to revert |
dkhalanskyjb
requested changes
Oct 14, 2025
| jsTest { | ||
| dependencies { | ||
| implementation(kotlin("test-js")) | ||
| implementation(kotlin("test")) |
There was a problem hiding this comment.
Is there a reason not to have a single kotlin("test") dependency in commonMain, like is done in the other build scripts in this PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "-js" dependencies are an unconventional way to specify dependencies, and these dependencies are problematic for testing lenient KMP resolution, which we are doing in KT-77297.
To make sure there is no impact, I published coroutines before and after these changes. Here is the diff. Now KMP Gradle JS consumers will see
atomicfucomponent instead ofatomicfu-js(which is the convention in KMP resolution), and there used to be some duplication in POM dependencies, which is now gone.