Doc rewrite update 3 - Serialize built in types #3082
Conversation
pdvrieze
left a comment
pdvrieze
left a comment
There was a problem hiding this comment.
I've added some comments. One thing to be clear about is the distinction between json and serialization in general. Json as example is good, but I would avoid giving the impression that serialization is json-only.
| ``` | ||
| {kotlin-runnable="true"} | ||
|
|
||
| Similarly, Kotlin's [`Instant`](https://kotlinlang.org/api/core/kotlin-stdlib/kotlin.time/-instant/) type |
There was a problem hiding this comment.
I explicitly mentioned that here should be Kotlin 2.2 requirement, as we do not version our docs and someone may open this section with the old Kotlin and get frustration because nothing is working.
sarahhaggarty
left a comment
sarahhaggarty
left a comment
There was a problem hiding this comment.
Nice page! Only a few clarification questions or suggestions from me. Can you add IDs to all your runnable samples so that we can track them in GA? 😃
| ### Unsigned numbers | ||
|
|
||
| Kotlin serialization supports Kotlin's [unsigned integer types](unsigned-integer-types.md) like `UByte` and `UInt`. | ||
| In JSON, these values are serialized as regular JSON numbers and preserve their full unsigned range: |
There was a problem hiding this comment.
What do you think about "retain" instead of "preserve"?
There was a problem hiding this comment.
I think I prefer preserve here slightly.
Retain to me is more like is more retain a state/ continue to exist. s
“preserve” feels closer to what's happening here maintain integrity / fidelity across a transformation.
| {style="note"} | ||
|
|
||
| #### Deserialization behavior of collections | ||
|
|
|
|
||
| ## What's next | ||
|
|
||
| * Dive into the [Serialize classes](serialization-customization-options.md) section to learn how to serialize classes and how to modify the default behavior of the `@Serializable` annotation. |
There was a problem hiding this comment.
Similar comment to the get started PR about whether this is an actual page or a section within the page.
This is the third part of the Kotlin Serialization rewrite.
Related YouTract ticket is: KT-80887 [Docs] Create a serialize built-in classes guide for kotlinx.serialization