-
-
Notifications
You must be signed in to change notification settings - Fork 22
Update and improve First App guide in spanish #75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
henrystivens
commented
Aug 19, 2025
- Clarified MVC architecture and URL handling explanations
- Updated controller and view examples
- Improved section titles for better readability
- Replaced and refreshed screenshots
- Clarified MVC architecture and URL handling explanations - Updated controller and view examples - Improved section titles for better readability - Replaced and refreshed screenshots
…d a note on using h() function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR significantly improves the Spanish First App guide for KumbiaPHP by modernizing the documentation structure, enhancing explanations, and updating examples with current best practices.
- Updated controller naming from Spanish to English conventions (SaludoController → GreetingsController)
- Improved MVC architecture explanations with clearer step-by-step breakdowns
- Modernized code examples with better documentation and security practices
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
<h1>Hola <?php echo $nombre ?> , ¡Que lindo es utilizar KumbiaPHP! | ||
¿cierto?</h1> | ||
<?php echo $fecha ?> | ||
<h1>Hola <?= h($name) ?>, ¡Qué lindo es utilizar KumbiaPHP! ¿Cierto?</h1> |
Copilot
AI
Aug 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good security practice using the h() function to escape the $name parameter and prevent XSS attacks.
Copilot uses AI. Check for mistakes.
<?php echo Html::link('saludo/hola/CaChi/', 'Volver a saludar') ?> | ||
<h1>¡Adiós <?= h($name) ?>! 👋</h1> | ||
<p>Esperamos verte pronto de nuevo.</p> | ||
<?= Html::linkAction('hello/' . $name, 'Volver a saludar') ?> |
Copilot
AI
Aug 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consistent use of h() function for escaping user input, maintaining security best practices throughout the tutorial.
<?= Html::linkAction('hello/' . $name, 'Volver a saludar') ?> | |
<?= Html::linkAction('hello/' . h($name), 'Volver a saludar') ?> |
Copilot uses AI. Check for mistakes.
<?php echo Html::link('saludo/hola/CaChi/', 'Volver a saludar') ?> | ||
<h1>¡Adiós <?= h($name) ?>! 👋</h1> | ||
<p>Esperamos verte pronto de nuevo.</p> | ||
<?= Html::linkAction('hello/' . $name, 'Volver a saludar') ?> |
Copilot
AI
Aug 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using Html::linkAction() instead of Html::link() is more appropriate for linking to actions within the same controller, improving code clarity and maintainability.
Copilot uses AI. Check for mistakes.