Skip to content

Conversation

henrystivens
Copy link
Member

  • Clarified MVC architecture and URL handling explanations
  • Updated controller and view examples
  • Improved section titles for better readability
  • Replaced and refreshed screenshots

- Clarified MVC architecture and URL handling explanations
- Updated controller and view examples
- Improved section titles for better readability
- Replaced and refreshed screenshots
@henrystivens henrystivens requested a review from joanhey August 19, 2025 23:34
@henrystivens henrystivens self-assigned this Aug 19, 2025
@henrystivens henrystivens requested a review from Copilot August 21, 2025 23:58
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR significantly improves the Spanish First App guide for KumbiaPHP by modernizing the documentation structure, enhancing explanations, and updating examples with current best practices.

  • Updated controller naming from Spanish to English conventions (SaludoController → GreetingsController)
  • Improved MVC architecture explanations with clearer step-by-step breakdowns
  • Modernized code examples with better documentation and security practices

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

<h1>Hola <?php echo $nombre ?> , ¡Que lindo es utilizar KumbiaPHP!
¿cierto?</h1>
<?php echo $fecha ?>
<h1>Hola <?= h($name) ?>, ¡Qué lindo es utilizar KumbiaPHP! ¿Cierto?</h1>
Copy link

Copilot AI Aug 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good security practice using the h() function to escape the $name parameter and prevent XSS attacks.

Copilot uses AI. Check for mistakes.

<?php echo Html::link('saludo/hola/CaChi/', 'Volver a saludar') ?>
<h1>¡Adiós <?= h($name) ?>! 👋</h1>
<p>Esperamos verte pronto de nuevo.</p>
<?= Html::linkAction('hello/' . $name, 'Volver a saludar') ?>
Copy link

Copilot AI Aug 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consistent use of h() function for escaping user input, maintaining security best practices throughout the tutorial.

Suggested change
<?= Html::linkAction('hello/' . $name, 'Volver a saludar') ?>
<?= Html::linkAction('hello/' . h($name), 'Volver a saludar') ?>

Copilot uses AI. Check for mistakes.

<?php echo Html::link('saludo/hola/CaChi/', 'Volver a saludar') ?>
<h1>¡Adiós <?= h($name) ?>! 👋</h1>
<p>Esperamos verte pronto de nuevo.</p>
<?= Html::linkAction('hello/' . $name, 'Volver a saludar') ?>
Copy link

Copilot AI Aug 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using Html::linkAction() instead of Html::link() is more appropriate for linking to actions within the same controller, improving code clarity and maintainability.

Copilot uses AI. Check for mistakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant