benchmark_inference: Allow passing cache option as cli arg #2695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshitij12345
requested review from
KaelanDt,
lantiga,
mruberry and
t-vi
as code owners
kshitij12345
requested review from
crcrpar,
jjsjann123,
riccardofelluga and
wujingyue
beverlylytle
approved these changes
Oct 24, 2025
Collaborator
beverlylytle
left a comment
beverlylytle
left a comment
There was a problem hiding this comment.
Looks good, thanks!
crcrpar
approved these changes
Oct 24, 2025
Collaborator
riccardofelluga
left a comment
riccardofelluga
left a comment
There was a problem hiding this comment.
Nit on the name of the option but the rest looks good, thanks for the PR 🙏
Collaborator
Author
|
Ping @KaelanDt for review |
Collaborator
Author
|
Failures in CI testing / pytester (macOS-15, 3.10, nightly, core) (pull_request) and |
KaelanDt
approved these changes
Nov 4, 2025
Collaborator
There was a problem hiding this comment.
Failed tests unrelated so merging, thank you @kshitij12345
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just allows choosing
cacheoption for thunder as CLI argument