Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ classifiers = [
]
dependencies = [
# download models:
"huggingface-hub>=0.30,<0.35",
"huggingface-hub>=0.30,<0.36",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I would drastically prefer that we allow a much broader range. <1 is what transformers use.

Suggested change
"huggingface-hub>=0.30,<0.36",
"huggingface-hub>=0.30,<1",

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is currently a blocker for Thunder to use newer litgpt.

"jsonargparse[signatures]>=4.31,<=4.32.1; python_version<'3.10'", # 4.33 does not seem to be compatible with Python 3.9
"jsonargparse[signatures]>=4.37; python_version>'3.9'", # required to work with python3.12+
"lightning>=2.5",
Expand Down
Loading