Skip to content
This repository was archived by the owner on Aug 28, 2025. It is now read-only.

Conversation

Borda
Copy link
Contributor

@Borda Borda commented Apr 10, 2022

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

In case some notebook request a specific torchvision or torchtext version all related packages shall be updated
So if torchvision is updated (it hall automatically reinstall torch) but then also torchtext shall be updated

  1. check if any of these packages were changed
  2. if so check mapping table and adjust remaining packages

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the bug / fix Something isn't working label Apr 10, 2022
@codecov
Copy link

codecov bot commented Apr 10, 2022

Codecov Report

Merging #155 (2335659) into main (c257c46) will not change coverage.
The diff coverage is n/a.

@@         Coverage Diff         @@
##           main   #155   +/-   ##
===================================
  Coverage    75%    75%           
===================================
  Files         2      2           
  Lines       355    355           
===================================
  Hits        267    267           
  Misses       88     88           

@Borda
Copy link
Contributor Author

Borda commented May 17, 2022

based on the discussion in #172 these adjustments need to be projected to the pip installation command in the notebook top section as this collision may also happen while running in Colab which already has some pre-instaled versions...

@Borda Borda force-pushed the main branch 2 times, most recently from d4acf6f to ac8f7ba Compare July 19, 2024 21:12
@Borda Borda changed the title CI: reinstall torch versions CI: reinstall torch* versions Jul 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug / fix Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant