This repository was archived by the owner on Jul 9, 2019. It is now read-only.
Unit test for the PasswordGrantExtension #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| */ | ||
| class PasswordGrantExtensionTest extends \PHPUnit_Framework_TestCase | ||
| { | ||
| public function testConfigureRequestParameters() |
|
|
||
| $actualDefinedOptions = $optionsResolver->getRequiredOptions(); | ||
| $expectedDefinedOptions = ['password', 'username']; | ||
| $this->assertEquals($expectedDefinedOptions, $actualDefinedOptions, '', $delta = 0.0, 10, true); // Not caring about keys |
Contributor
There was a problem hiding this comment.
Mais il faut aussi tester que les options optionnelles existent toujours.
| $userPasswordEncoderMock = $this->prophesize(UserPasswordEncoderInterface::class); | ||
| $userPasswordEncoderMock->isPasswordValid(Argument::type(UserInterface::class), 'password_test')->willReturn(true)->shouldBeCalled(); | ||
| /** @var UserPasswordEncoderInterface $userPasswordEncoder */ | ||
| $userPasswordEncoder = $userPasswordEncoderMock->reveal(); |
Contributor
There was a problem hiding this comment.
fait le dans le constructeur
| /** @var LoginAttempt $loginAttempt */ | ||
| $loginAttempt = $loginAttemptMock->reveal(); | ||
|
|
||
| $actualAccount = $passwordGrantExtension->grant($application, $loginAttempt); |
Contributor
There was a problem hiding this comment.
$actualAccount = $passwordGrantExtension->grant(
$application->reveal(),
$loginAttempt->reveal()
);
Contributor
|
@Raphy please squash your commits ! |
| $this->assertEquals($expectedRequiredOptions, $actualRequiredOptions, '', $delta = 0.0, 10, true); // Not caring about keys | ||
|
|
||
| // Testing the optional options | ||
| $actualOptionalOptions = array_diff($optionsResolver->getDefinedOptions(), $actualRequiredOptions); |
Contributor
There was a problem hiding this comment.
Pourquoi faire la distinction ? Ce que tu veux tester ici, c'est que les options définies le sont toujours, une option obligatoire est requise donc tu peux la tester.
Contributor
|
Oui squash les commits ;) 📦 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.