Depend on updated bitcoin-ffi w/ procmacros #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bitcoin-ffi merged procmacro support. this PR is no longer blocked and can be updated to point to the latest commit, or better yet, a new release when one comes. |
DanGould
force-pushed
the
bitcoin-ffi-procmacros
branch
from
33fc7f3 to
a725b7a
Compare
|
Rebased on main and to use bitcoindevkit/bitcoin-ffi#34. There is a bug in 0.29.0 that prevents bitcoin-ffi from being embedded downstream, so I have to point to that branch for now |
DanGould
force-pushed
the
bitcoin-ffi-procmacros
branch
from
a725b7a to
6ccb4d6
Compare
spacebear21
approved these changes
Mar 24, 2025
DanGould
force-pushed
the
bitcoin-ffi-procmacros
branch
from
6ccb4d6 to
b9eacf3
Compare
spacebear21
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few bitcoin-ffi updates, including procmacros.
We want to make some other updates too that will follow including function signatures that use bitcoin_ffi types instead of just strings in places, but that may follow.