-
-
Notifications
You must be signed in to change notification settings - Fork 385
插件问题修复 #3285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
插件问题修复 #3285
Conversation
… marking in luadoc.lua. Skip virtual sources during function checks and ensure documentation nodes are marked as virtual for better processing.
Summary of ChangesHello @ushen-pyj, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 此拉取请求旨在解决与插件功能相关的问题,通过改进代码库中“虚拟”节点的处理方式。它引入了一种机制,用于明确标记虚拟节点,并在源查找过程中忽略它们,从而防止它们干扰核心源识别逻辑。这一更改提高了源解析的准确性和健壮性,特别是对于插件生成的文档。 Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
你好,感谢你对这个问题的修复。这个 PR 通过引入 virtual 标记来区分插件生成的文档节点,并在 find-source 中过滤掉这些虚拟节点,从而解决了 issue #3284 中描述的问题。markVirtual 函数递归地标记了所有子节点,确保了标记的完整性。代码改动方向正确,逻辑清晰。我只发现了一个可以优化的小地方,请看我的具体评论。
| doc.virtual = true | ||
| markVirtual(doc) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…mline processing of plugin documentation.
…nd behavior issues
#3284 关于我的这个issue
我自己试着看了一下源码,修复了一下