GH-598: Receivables scheduling hot fix #750
Open
+410
−268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utkarshg6
reviewed
Dec 5, 2025
|
|
||
| #[derive(Debug, PartialEq, Eq, Clone, Copy)] | ||
| pub enum PayableSequenceScanner { | ||
| pub enum StartScanFallibleScanner { |
Collaborator
There was a problem hiding this comment.
Consider renaming it to FallibleScanner.
utkarshg6
reviewed
Dec 5, 2025
|
|
||
| pub fn schedule_new_payable_scan(&self, ctx: &mut Context<Accountant>, logger: &Logger) { | ||
| if let ScanTiming::WaitFor(interval) = self.interval_computer.time_until_next_scan() { | ||
| if let ScanTiming::WaitFor(interval) = self.interval_computer.compute_time_to_next_scan() { |
utkarshg6
reviewed
Dec 5, 2025
| impl RescheduleScanOnErrorResolverReal { | ||
| fn resolve_new_payables( | ||
| err: &StartScanError, | ||
| is_externally_triggered: bool, |
Collaborator
There was a problem hiding this comment.
I have an idea!
How about StartScanError are of following types:
enum StartScanError {
Automatic(AutomaticError),
Manual(ManualError),
Test
}
enum AutomaticError {
ScanAlreadyRunning {
cross_scan_cause_opt: Option<ScanType>,
started_at: SystemTime,
},
Common(CommonError)
}
enum ManualError {
AutomaticScanConflict,
UnnecessaryRequest { hint_opt: Option<String> },
Common(CommonError)
}
enum CommonError {
NothingToProcess,
NoConsumingWalletFound
}This way, we can get rid of the flag is_externally_triggered and hopefully unreachable!() too if we refactor it further.
utkarshg6
reviewed
Dec 5, 2025
| pub fn build_and_provide_addresses(self) -> (PeerActors, PeerActorAddrs) { | ||
| // | ||
| // The addresses may be helpful for setting up the Counter Messages. | ||
| pub fn build_providing_addresses(self) -> (PeerActors, PeerActorAddrs) { |
Collaborator
There was a problem hiding this comment.
build_and_provide_addresses was a better name.
utkarshg6
reviewed
Dec 5, 2025
| Err(e) => | ||
| // Any error here panics by design, so the return value is unreachable/ignored. | ||
| { | ||
| self.handle_start_scan_error_and_prevent_scan_stall_point( |
Collaborator
There was a problem hiding this comment.
This name's huge. Pick one: resolve_scan_error or handle_scan_error_and_reschedule.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Refactors scan scheduling/rescheduling to use a new unified scanner enum, adds explicit Receivables error handling, renames the interval-computation API, and updates tests and recorder utilities accordingly.
PayableSequenceScannerwith unifiedStartScanFallibleScanner(addsReceivablesvariant) and updateDisplay/From→ScanType.CalledFromNullScanner; stricter unreachable cases.NewPayableScanIntervalComputer.time_until_next_scan→compute_time_to_next_scan; propagate across schedulers, mocks, and callers.ScanForReceivableshandler now delegates tohandle_request_of_scan_for_receivable()returningScanReschedulingAfterEarlyStop; unreachable follow-ups guarded.ReceivedPaymentsnow reschedules the receivable scan via scheduler;handle_request_of_scan_for_receivable()returns a hint and usesStartScanFallibleScanner::Receivableson errors.StartScanFallibleScanner::{New,Retry,Pending,Receivables}.build_and_provide_addresses→build_providing_addresses; update usages.compute_time_to_next_scan_params_*).Written by Cursor Bugbot for commit e2ca807. This will update automatically on new commits. Configure here.