Skip to content

Conversation

@StuartHarris
Copy link
Contributor

@StuartHarris StuartHarris commented Apr 8, 2021

  • update kube-state-metrics to work with the recently updated Kubernetes version (1.17)
  • separate out oms-agent manifests
  • group prometheus, oms-agent and kube-state-metrics under observability folder
  • update Makefile in cluster-init
  • manifests for prometheus install
  • update prometheus config to use sidecar (without intercepting scrapes)
  • test config and remove old configmap
  • validate that metrics are being captured for Istio, K8s and our installed services

@StuartHarris StuartHarris changed the title Prometheus Observability with Istio 1.9 Apr 13, 2021
kubectl rollout restart deployment/argocd-server -n argocd
kubectl rollout restart deployment/doc-index-updater -n doc-index-updater
kubectl rollout restart deployment/medicines-api -n medicines-api
cd ../observability/prometheus && make
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small point, wondering if this line is valuable. Probs won't restart prometheus pods unless there's an update. Maybe we should update the readme to do the make instead? What do you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This command will be used when istio has been upgraded, in which case I think this line will cause the prometheus pod to restart due to istioctl kube-inject, which is what we want - is that right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, that's true. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants