-
Notifications
You must be signed in to change notification settings - Fork 3
Observability with Istio 1.9 #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| kubectl rollout restart deployment/argocd-server -n argocd | ||
| kubectl rollout restart deployment/doc-index-updater -n doc-index-updater | ||
| kubectl rollout restart deployment/medicines-api -n medicines-api | ||
| cd ../observability/prometheus && make |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small point, wondering if this line is valuable. Probs won't restart prometheus pods unless there's an update. Maybe we should update the readme to do the make instead? What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This command will be used when istio has been upgraded, in which case I think this line will cause the prometheus pod to restart due to istioctl kube-inject, which is what we want - is that right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, that's true. 👍
kube-state-metricsto work with the recently updated Kubernetes version (1.17)oms-agentmanifestsprometheus,oms-agentandkube-state-metricsunderobservabilityfolderMakefileincluster-initprometheusinstall