feature: load scene to tree, instead of changing to resource #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add resource to tree instead of changing scene to resource directly. This allows to do changes on the scene before changing to it. Also added a few signals so that I'm able to add fade effects on top of it.
|
Thanks for the PR! I apologize for the delay in reviewing it. I've been avoiding making big changes to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new load method to add the loaded resource to the tree, instead of changing scene to resource directly.
This allows to do changes on the scene before changing to it.
In my case, it allows me to wait for other peers to be ready and spawn the characters before showing the new scene.
Also added a few new signals so that I'm able to add fade effects on top of it.