Skip to content

Conversation

@nasark
Copy link
Member

@nasark nasark commented Dec 11, 2024

@miq-bot assign @agrare
@miq-bot add_reviewer @agrare

@nasark nasark requested review from Fryguy and agrare as code owners December 11, 2024 20:10
@nasark nasark changed the title Add Openstack prefix to Cinder and Swift managers Add Openstack prefix to Cinder and Swift manager descriptions Dec 11, 2024

def self.description
@description ||= "Cinder ".freeze
@description ||= "Openstack Cinder ".freeze
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CloudManager and NetworkManager both use OpenStack can you match that for all of these?

@nasark nasark force-pushed the openstack_prefix_cinder_swift_manager_descriptions branch from ee32950 to 5d78689 Compare December 11, 2024 21:29

def self.description
@description ||= "Cinder ".freeze
@description ||= "OpenStack Cinder ".freeze
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should drop the trailing spaces.

Suggested change
@description ||= "OpenStack Cinder ".freeze
@description ||= "OpenStack Cinder".freeze

@Fryguy
Copy link
Member

Fryguy commented Dec 11, 2024

Also, since we're making this change in a base provider, please run cross-repo tests with the descendant providers

@nasark nasark force-pushed the openstack_prefix_cinder_swift_manager_descriptions branch from 5d78689 to 3135ac9 Compare December 12, 2024 15:51
@nasark
Copy link
Member Author

nasark commented Dec 12, 2024

@miq-bot cross-repo-test manageiq-providers-ibm_cic, manageiq-providers-ibm_power_vc

@nasark
Copy link
Member Author

nasark commented Dec 12, 2024

manageiq-providers-ibm_cic and manageiq-providers-ibm_power_vc tests passed in the cross-repo. The openstack run failed with a qpid_proton failure and is not related

An error occurred while installing qpid_proton (0.37.0), and Bundler cannot
continue.

In Gemfile:
  qpid_proton

@agrare
Copy link
Member

agrare commented Dec 12, 2024

Oh we need a fix like #897 in those also

@miq-bot
Copy link
Member

miq-bot commented Mar 5, 2025

Checked commits nasark/manageiq-providers-openstack@463dab0~...3135ac9 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
2 files checked, 0 offenses detected
Everything looks fine. 🍪

@miq-bot miq-bot added the stale label Jun 9, 2025
@miq-bot
Copy link
Member

miq-bot commented Jun 9, 2025

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants