-
Notifications
You must be signed in to change notification settings - Fork 94
Add Openstack prefix to Cinder and Swift manager descriptions #898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add Openstack prefix to Cinder and Swift manager descriptions #898
Conversation
|
|
||
| def self.description | ||
| @description ||= "Cinder ".freeze | ||
| @description ||= "Openstack Cinder ".freeze |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CloudManager and NetworkManager both use OpenStack can you match that for all of these?
ee32950 to
5d78689
Compare
|
|
||
| def self.description | ||
| @description ||= "Cinder ".freeze | ||
| @description ||= "OpenStack Cinder ".freeze |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should drop the trailing spaces.
| @description ||= "OpenStack Cinder ".freeze | |
| @description ||= "OpenStack Cinder".freeze |
|
Also, since we're making this change in a base provider, please run cross-repo tests with the descendant providers |
5d78689 to
3135ac9
Compare
|
@miq-bot cross-repo-test manageiq-providers-ibm_cic, manageiq-providers-ibm_power_vc |
From Pull Request: ManageIQ/manageiq-providers-openstack#898
|
|
|
Oh we need a fix like #897 in those also |
|
Checked commits nasark/manageiq-providers-openstack@463dab0~...3135ac9 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
|
This pull request has been automatically marked as stale because it has not been updated for at least 3 months. If these changes are still valid, please remove the |
@miq-bot assign @agrare
@miq-bot add_reviewer @agrare