Skip to content

Conversation

RazvanLiviuVarzaru
Copy link
Collaborator

[4/4] patch in the series.
Merge after #776

Merge blocked by:

@RazvanLiviuVarzaru RazvanLiviuVarzaru force-pushed the mdbf/1060-valgrind-builder-f42 branch from 6878785 to befd334 Compare June 25, 2025 09:44
Copy link
Member

@grooverdan grooverdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So previously the columnstore failed to build on f40.

The MCOL bugs I see have commits pushed, so it just needs a server submodule update and merge up to have an effect. There is one columnstore test in mtr that requires the columnstore to be running to be executed. Disabling columnstore in this builder will allow this to be deployed before the MCOL fixes are merged. The other Fedora 42 builder and provide a compile build test.

So there's currently no dev run of the new valgrind/fedora version yet to see if there are regressions (as false positives or not)?

Just leave this to making the new container for the time being and explicitly disable the columnstore plugin in the build step (which failed on f40 anyway). Then see what the MTR run looks like before deciding to update the builder.

@RazvanLiviuVarzaru
Copy link
Collaborator Author

So previously the columnstore failed to build on f40.

The MCOL bugs I see have commits pushed, so it just needs a server submodule update and merge up to have an effect. There is one columnstore test in mtr that requires the columnstore to be running to be executed. Disabling columnstore in this builder will allow this to be deployed before the MCOL fixes are merged. The other Fedora 42 builder and provide a compile build test.

So there's currently no dev run of the new valgrind/fedora version yet to see if there are regressions (as false positives or not)?

Just leave this to making the new container for the time being and explicitly disable the columnstore plugin in the build step (which failed on f40 anyway). Then see what the MTR run looks like before deciding to update the builder.

So previously the columnstore failed to build on f40.

The MCOL bugs I see have commits pushed, so it just needs a server submodule update and merge up to have an effect. There is one columnstore test in mtr that requires the columnstore to be running to be executed. Disabling columnstore in this builder will allow this to be deployed before the MCOL fixes are merged. The other Fedora 42 builder and provide a compile build test.

So there's currently no dev run of the new valgrind/fedora version yet to see if there are regressions (as false positives or not)?

Just leave this to making the new container for the time being and explicitly disable the columnstore plugin in the build step (which failed on f40 anyway). Then see what the MTR run looks like before deciding to update the builder.

There's no run yet,
right, this requires more preparation, I guess there's no rush to upgrade this builder so I can take my time to set-up manually the environment and present some results.

At this point, I think it's best to have a separate MDBF for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants