#343 feat(domain) Aggregation Resilience #345
Conversation
|
|
||
| it('should give the valid posts only', async () => | ||
| { | ||
| await remove(REQUESTERS.CREATOR1, VALUES.IDS.POST_RATED); |
There was a problem hiding this comment.
This remove call modifies the test fixtures to fit the test assertions below, basically saying that the fixtures do not support this test scenario. Instead of calling the remove function, we need to update the fixtures.
| describe('domain/notification/getallAggregated', () => | ||
| { | ||
| it('should give all posts for the requester', async () => | ||
| it('should give all posts for the requester2', async () => |
There was a problem hiding this comment.
As discussed before, this description should tell what scenario is tested. Getting the posts (notifications?) for requester 2 doesn't say anything. It should be clear what's wrong if this test case fails.
| describe('domain/notification/getallAggregated', () => | ||
| { | ||
| it('should give all posts for the requester', async () => | ||
| it('should give all notifications for the requester2', async () => |
There was a problem hiding this comment.
| it('should give all notifications for the requester2', async () => | |
| it('should give all notifications under normal circumstances', async () => |
The specific requester doesn't matter because it's fixture related, and is not a part of what we're testing.
| expect(notification3.relation.following.id).toBe(VALUES.IDS.CREATOR2); | ||
| }); | ||
|
|
||
| it('should give only the notifications without aggregation errors for requester1', async () => |
There was a problem hiding this comment.
| it('should give only the notifications without aggregation errors for requester1', async () => | |
| it('should filter out deleted notifications without aggregation errors', async () => |
The specific requester doesn't matter because it's fixture related, and is not a part of what we're testing.
|
2 participants
Fixes #
Changes proposed in this pull request:
@MaskingTechnology/comify