Skip to content

feat: react on reactions #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jan 13, 2025
Merged

feat: react on reactions #365

merged 9 commits into from
Jan 13, 2025

Conversation

johnmasking
Copy link
Member

@johnmasking johnmasking commented Jan 6, 2025 •
edited
Loading

Fixes #347

Changes proposed in this pull request:

  • Added several routes for highlights
  • Added Back button to reactionDetails
  • Added getByReactionAggregated function for reaactions
  • Added tests
  • Added domain code for add reaction to a reaction.
  • Added domain code for new notification types

@MaskingTechnology/comify

@johnmasking johnmasking linked an issue Jan 6, 2025 that may be closed by this pull request
React to reactions #347
Closed
@basmasking basmasking changed the title #347 feat( feat(domain): react on reactions Jan 7, 2025
@petermasking petermasking changed the title feat(domain): react on reactions feat: react on reactions Jan 10, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
5.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@petermasking petermasking merged commit b05e083 into main Jan 13, 2025
5 of 6 checks passed
@petermasking petermasking deleted the 347-react-to-reactions branch January 13, 2025 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petermasking petermasking petermasking approved these changes

@basmasking basmasking Awaiting requested review from basmasking basmasking is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

React to reactions

2 participants

@johnmasking @petermasking