368 upgrade to jitar v09 #369
Conversation
| @@ -1,10 +1,10 @@ | |||
|
|
|||
| import getImageData from '^/domain/image/getById/feature'; | |||
| import getImageData from '^/domain/image/getById/getById'; | |||
There was a problem hiding this comment.
Imports directly, instead of using index file
src/domain/comic/create/create.ts
Outdated
| @@ -1,13 +1,13 @@ | |||
|
|
|||
| import createImage from '^/domain/image/create/feature'; | |||
| import createImage from '^/domain/image/create/create'; | |||
There was a problem hiding this comment.
Imports directly, instead of using index file
| @@ -1,10 +1,10 @@ | |||
|
|
|||
| import getImageData from '^/domain/image/getById/feature'; | |||
| import getImageData from '^/domain/image/getById/getById'; | |||
There was a problem hiding this comment.
Imports directly, instead of using index file
| @@ -1,5 +1,5 @@ | |||
|
|
|||
| import downloadImage from '^/domain/image/download/feature'; | |||
| import downloadImage from '^/domain/image/download'; | |||
There was a problem hiding this comment.
Imports directly, instead of using index file
There was a problem hiding this comment.
Imports from the feature's index file?
There was a problem hiding this comment.
I must be mistaken, but this is indeed correct.
src/domain/image/create/create.ts
Outdated
| @@ -0,0 +1,13 @@ | |||
|
|
|||
| import save from '../save/save'; | |||
There was a problem hiding this comment.
Imports directly, instead of using index file
| @@ -0,0 +1,12 @@ | |||
|
|
|||
| import { Requester } from '^/domain/authentication'; | |||
| import createComic from '^/domain/comic/create/create'; | |||
There was a problem hiding this comment.
Imports directly, instead of using index file
| @@ -1,5 +1,5 @@ | |||
|
|
|||
| import database from '^/integrations/database/module'; | |||
| import database from '^/integrations/database/index.js'; | |||
| import updateNickname from '^/domain/creator/updateNickname/feature'; | ||
| import { requester } from '^/domain/authentication'; | ||
| import type { AggregatedData as AggregatedCreatorData } from '^/domain/creator/aggregate'; | ||
| //import updateNickname, { NicknameAlreadyExists } from '^/domain/creator/updateNickname'; |
There was a problem hiding this comment.
Comment doesn't seem deleted.
test/domain/comic/create.spec.ts
Outdated
| @@ -1,10 +1,10 @@ | |||
|
|
|||
| import { beforeEach, describe, expect, it } from 'vitest'; | |||
|
|
|||
| import create from '^/domain/comic/create/feature'; | |||
| import create from '^/domain/comic/create/create'; | |||
There was a problem hiding this comment.
Imports directly, instead of using index file
| @@ -1,12 +1,12 @@ | |||
|
|
|||
| import johnDoe from '^/domain/authentication/requester'; | |||
| import { requester } from '^/domain/authentication'; | |||
| import { Requester } from '^/domain/authentication/types'; | |||
There was a problem hiding this comment.
Imports directly, instead of using index file
|
Fixes #361
Fixes #368
Changes proposed in this pull request:
@MaskingTechnology/comify