feat: event support #380
Merged
feat: event support #380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
basmasking
requested changes
Feb 7, 2025
| { | ||
| const query = { creatorId: { EQUALS: creatorId } }; | ||
|
|
||
| const data = database.findRecord(RECORD_TYPE, query) as Promise<DataModel>; |
There was a problem hiding this comment.
We should await the promise to be able to check the data itself
| { | ||
| const query = { postId: { EQUALS: postId } }; | ||
|
|
||
| const data = database.findRecord(RECORD_TYPE, query) as Promise<DataModel>; |
There was a problem hiding this comment.
We have to await the promise to be able to check the value of data
| type AggregatedData = Omit<DataModel, 'email' | 'portraitId'> & | ||
| { | ||
| readonly portrait?: ImageData; | ||
| metrics: metricsData; |
|
|
||
| import { Types } from '../definitions'; | ||
|
|
||
| import getPost from '^/domain/post/getById'; |
| { | ||
| constructor() | ||
| { | ||
| super('Creator metrics not found'); |
| import type { AggregatedData as AggregatedReactionData } from '^/domain/reaction/aggregate'; | ||
| import createComicReaction from '^/domain/reaction/createWithComic'; | ||
| import getReaction from '^/domain/reaction/getByIdAggregated'; | ||
| import createComicReaction from '^/domain/post/createWithComic'; |
There was a problem hiding this comment.
Shouldn't this be createComicPost?
| import type { AggregatedData as AggregatedReactionData } from '^/domain/reaction/aggregate'; | ||
| import createCommentReaction from '^/domain/reaction/createWithComment'; | ||
| import getReaction from '^/domain/reaction/getByIdAggregated'; | ||
| import createCommentReaction from '^/domain/post/createWithComment'; |
There was a problem hiding this comment.
Shouldn't this be createCommentPost?
| import { useNavigate } from 'react-router-dom'; | ||
|
|
||
| import { Types } from '^/domain/notification'; | ||
| import type { AggregatedData as NotificationView } from '^/domain/notification/aggregate/types'; |
| { | ||
| const navigate = useNavigate(); | ||
|
|
||
| return useCallback((notification: NotificationView) => |
| import { beforeEach, describe, expect, it } from 'vitest'; | ||
|
|
||
| import getAllAggregated from '^/domain/post/getAllAggregated'; | ||
| import getAllAggregated from '^/domain/post/getRecommendedAggregated'; |
|
basmasking
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #373
Fixes #370
Changes proposed in this pull request:
@MaskingTechnology/comify