chore: update of openid-client implementation #381
Merged
+366
−327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petermasking
requested changes
Feb 7, 2025
Comment on lines
30
to
31
| readonly #configuration: OpenIDConfiguration; | ||
| #config?: Configuration; |
There was a problem hiding this comment.
Both names might be clear on their own, but combined their quite confusing...
Suggested change
| readonly #configuration: OpenIDConfiguration; | |
| #config?: Configuration; | |
| readonly #providerConfiguration: OpenIDConfiguration; | |
| #clientConfiguration?: Configuration; |
|
|
||
| const tokenSet = await client.callback(redirectUri, data); | ||
| const userinfo = await client.userinfo(tokenSet.access_token as string); | ||
| const sub = claims!.sub as string; |
There was a problem hiding this comment.
According to the docs, the claims can be undefined when the auth server doesn't return a expires_in value. Shouldn't we check this?
|
petermasking
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #364
Closes #379
Changes proposed in this pull request:
@MaskingTechnology/comify