-
Notifications
You must be signed in to change notification settings - Fork 3
chore: demo preparation #412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
152e02d
83e3311
cee473d
13d4fc8
fc862fb
79dc68f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,7 @@ | ||
{ | ||
"./domain/notification/create": { "default": { "access": "protected" } }, | ||
"./domain/notification/getById": { "default": { "access": "protected" } }, | ||
"./domain/notification/getRecent": { "default": { "access": "protected" } } | ||
"./domain/notification/getByPostId": { "default": { "access": "protected" } }, | ||
"./domain/notification/getRecent": { "default": { "access": "protected" } }, | ||
"./domain/notification/remove": { "default": { "access": "protected" } } | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,6 +9,7 @@ | |
"./domain/creator/update": { "default": { "access": "protected" } }, | ||
|
||
"./domain/creator.metrics/create/insertData": { "default": { "access": "protected" } }, | ||
"./domain/creator.metrics/update": { "default": { "access": "protected" } }, | ||
|
||
"./domain/image/save": { "default": { "access": "protected" } }, | ||
"./domain/image/erase": { "default": { "access": "protected" } }, | ||
|
@@ -19,6 +20,7 @@ | |
"./domain/post/update": { "default": { "access": "protected" } }, | ||
|
||
"./domain/post.metrics/create/insertData": { "default": { "access": "protected" } }, | ||
"./domain/post.metrics/update": { "default": { "access": "protected" } }, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Verification agent 🧩 Analysis chainAdd protected post metrics update operation. You can verify its presence with: 🏁 Script executed: #!/bin/bash
rg -l '"update"' -g 'src/domain/post.metrics/*' Length of output: 49 🏁 Script executed: #!/bin/bash
# List all files under src/domain/post.metrics to verify existence of the module
echo "=== Files in src/domain/post.metrics ==="
find src/domain/post.metrics -maxdepth 1 -type f
# Search for any occurrence of the word 'update' (unquoted) in that directory
echo "=== Searching for 'update' keyword ==="
rg -n 'update' -g 'src/domain/post.metrics/*' Length of output: 385 Missing
🤖 Prompt for AI Agents
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The segmentation files also support index resolution. So implicitly There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain@basmasking Thank you for the clarification! I understand now that the segmentation files support index resolution, so 🏁 Script executed:
Length of output: 562 @basmasking Perfect! I can confirm that the The entry for
✏️ Learnings added
If you found this review helpful, would you consider giving us a shout-out on X? Thank you for using CodeRabbit! |
||
|
||
"./domain/rating/create": { "default": { "access": "protected" } }, | ||
"./domain/rating/erase": { "default": { "access": "protected" } }, | ||
|
Original file line number | Diff line number | Diff line change | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
@@ -1,13 +1,12 @@ | ||||||||||||||||||
{ | ||||||||||||||||||
"url": "http://127.0.0.1:4001", | ||||||||||||||||||
"setUp": [ | ||||||||||||||||||
"./integrations/runtime/setUpNode" | ||||||||||||||||||
"./integrations/runtime/setUpWorker" | ||||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Verification agent 🧩 Analysis chainVerify the setup script choice for notification service. The notification service is configured to use Also applies to: 7-7 🏁 Script executed: #!/bin/bash
# Description: Verify if notification service should use different setup script
# Expected: Check if there's a specific setup for notification services or if this is intentional
echo "Checking available setup scripts:"
fd "setUp.*\.ts$" src/integrations/runtime
echo -e "\nContent of tearDownWorker.ts:"
cat src/integrations/runtime/tearDownWorker.ts 2>/dev/null || echo "tearDownWorker.ts not found"
echo -e "\nSearching for notification-specific setup scripts:"
fd ".*[Nn]otification.*\.ts$" src/integrations/runtime Length of output: 1244 🏁 Script executed: #!/bin/bash
# Inspect setUpWorker.ts to see which services it connects
echo "== Content of setUpWorker.ts =="
cat src/integrations/runtime/setUpWorker.ts || echo "ERROR: setUpWorker.ts not found"
echo -e "\n== References to notificationService in setUpWorker.ts =="
grep -R "notificationService" -n src/integrations/runtime/setUpWorker.ts || echo "No notificationService.connect calls found" Length of output: 881 🏁 Script executed: #!/bin/bash
# Display notification service configuration for review
echo "== services/notification.json =="
cat services/notification.json Length of output: 518 Fix notification service setup and health checks The notification service is currently using Please update
🤖 Prompt for AI Agents
|
||||||||||||||||||
], | ||||||||||||||||||
"tearDown": [ | ||||||||||||||||||
"./integrations/runtime/tearDownNode" | ||||||||||||||||||
"./integrations/runtime/tearDownWorker" | ||||||||||||||||||
], | ||||||||||||||||||
"healthChecks": [ | ||||||||||||||||||
"./integrations/runtime/notificationHealthCheck", | ||||||||||||||||||
"./integrations/runtime/databaseHealthCheck" | ||||||||||||||||||
], | ||||||||||||||||||
Comment on lines
9
to
11
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Verification agent 🧩 Analysis chainQuestionable removal of notification health check. Removing the notification health check from the notification service configuration seems counterintuitive. A notification service should typically monitor its own health to ensure it can properly handle notification operations. 🏁 Script executed: #!/bin/bash
# Description: Check if notification health check exists and understand why it was removed
# Expected: Find notification health check implementation and other service configs for comparison
echo "Searching for notification health check implementation:"
fd "*[Nn]otification*[Hh]ealth*" --type f
echo -e "\nComparing health checks across service configurations:"
fd "*.json" services/ --exec sh -c 'echo "=== $1 ===" && jq ".healthChecks" "$1"' -- Length of output: 969 To correct the pattern errors and surface any missing health checks, let’s re-run with proper glob matching: 🏁 Script executed: #!/bin/bash
set -e
echo "Searching for notification health check implementation:"
# Look for any file whose name includes “notification” and “health”
fd --glob '*notification*health*' --type f
echo -e "\nComparing healthChecks across all service configs:"
# For each JSON in services/, print its .healthChecks array
fd --glob '*.json' services/ --exec sh -c '
echo "=== $1 ==="
jq ".healthChecks" "$1"
' _ {} \; Length of output: 1307 Add NotificationHealthCheck back into notification service • services/notification.json (lines 9–11):
Suggested diff: "healthChecks": [
- "./integrations/runtime/databaseHealthCheck"
+ "./integrations/runtime/notificationHealthCheck",
+ "./integrations/runtime/databaseHealthCheck"
], 📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents
|
||||||||||||||||||
"worker": | ||||||||||||||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Add protected creator metrics update operation.
The new entry for
"./domain/creator.metrics/update"
correctly marks the update operation as protected. Ensure the corresponding module exists and is exported under that path.You can verify its presence with:
🏁 Script executed:
Length of output: 52
I’m not finding any module named
update
undersrc/domain/creator.metrics
. Let’s list all files in that directory to confirm:🏁 Script executed:
Length of output: 101
It looks like there’s no
update
file insrc/domain/creator.metrics
. Let’s check if any of the existing files export or mention an update operation:🏁 Script executed:
Length of output: 48
Missing
update
module increator.metrics
The new entry in
segments/writes.json
references./domain/creator.metrics/update
, but there’s no corresponding file undersrc/domain/creator.metrics/
. You’ll need to either:• Add an
update.ts
(or.js
) module exporting the update operation atsrc/domain/creator.metrics/update
• Or adjust the JSON path to point at an existing module (e.g. consolidate under
index.ts
)Please update the code or mapping so that the protected operation actually exists.
🤖 Prompt for AI Agents